-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.5.23 not working on Windows XP #61
Comments
Does it work with the current vs2015 artifact? |
@GitMensch, I tried, but unfortunately it is threw the same error with this too. |
As I remember under VS2015 we should explicitly enable XP support in project settings. I believe VS2019 doesn't support XP anymore. You can try to build bison source code using VS2015 with proper settings but it might not compile because of outdated С++ compiler. |
I think we should set the cmake up to let the VC2015 environment use the -xp toolset. |
I don't have VS2015 to test it. |
I have added XP support to appveyor script. The following artifact should support XP @a11apurva Please verify. |
Hi @lexxmark, works as expected.
Thanks a lot! Closing the issue. |
Hm, I think one last piece is missing:
@lexxmark what do you think? |
Yes that makes sense.
@a11apurva why did you test on Windows7 system and not WindowsXP? |
That was such a blunder. Apologies. Same error on XP still -
|
Please directly |
@lexxmark You set the VC var PLATFORMTOOLSET, but this is only honored by msbuild. My guess is that CMAKE_VS_PLATFORM_TOOLSET should be set from this variable. |
Can you try this? |
I haven't tested on XP yet as the machine is down, but it says Bison 3.7.4, is this the correct package? |
yes, that's correct. I'm migrating to bison 3.7.4 if it works we can rollup windows XP fix for any version we need. |
It seems I have to manage to enforce Visual Studio to build project with v140_xp toolset. The only problem still is that appveyor don't supply VS with such a toolset. Have to dig further. |
We have moved all our systems to win10. If there are no other takers for the Bison with XP support then you guys can park this for now. |
OK, I'm going to remove VS2015 support and all XP stuff then. I think VS2017/VS2019 support would be enough. |
I initially was thinking that this is a bad idea, but came to the conclusion that this is fine - people can use an older version for old parsers. The question is: what is the latest release that actually has XP support? Maybe we can hand-craft a version and attach it to one of the releases, adding a release note "last with XP support"? |
@GitMensch Are you talking about winflexbison3? I think the regular winflexbison2 last version has XP support. Someone who will need XP support will help us determine exact winflexbison3 version supporting XP then. I hope no one needed XP support anymore. |
I've jsut tested that with an old VM (Windows Version 5.1 XP SP3 32bit). Yes, winflexbison2 last version works, winflexbison 2.5.22 (bison 3.5.0, flex 2.6.4) is the most current one that works, from 2.5.23 I see the same failures as here. ... this does make me wonder: what has changed in between? |
My guess is that I just started to create releases by new version of Visual Studio which doesn't support XP any more. |
We migrated our entire project to v2.5.23 (Bison-3.7.1) and everything worked wonderfully on Windows 10. However today when I tried on windows-XP I am getting the following error -
bison: cannot execute: %1 is not a valid Win32 application.
Win 10 -
Win XP -
Can you please help? I was able to build my project on XP using the Bison executable for Bison-2.4
edit -
The text was updated successfully, but these errors were encountered: