-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table extension does not follow GFM spec (cannot interrupt a paragraph) #15
Comments
Thanks @marijnh, looks great! Would you mind tagging this as a new version? |
Sure -- done |
Awesome, thank you. I think @codemirror/lang-markdown might need to be bumped too though, as I'm now seeing some type incompatibilities between the two (specifically around the |
No, just reinstall your dependencies to force npm to properly deduplicate them (it has an issue where upgrading will often inappropriately install multiple versions of a package). |
Additionally, is there a reason why |
In the GFM spec, all
leaf
blocks are allowed to interrupt a paragraph, for example a fenced code block can appear in the text immediately after other text with no line breaks, like so:And this markdown parser respects that part of the spec. However, I've noticed that the Table extension provided by the lib does not follow this convention, and if a Table interrupts a paragraph lezer does not recognize it as such.
Easiest way to demonstrate is probably that Github's markdown parser, which follows the spec exactly AFAIK, allows this behavior, like so:
Anyway just thought I'd point this out, thanks for making such a cool parsing library!
The text was updated successfully, but these errors were encountered: