-
Notifications
You must be signed in to change notification settings - Fork 155
/
appnetwork.go
408 lines (377 loc) · 14.8 KB
/
appnetwork.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
// Copyright (c) 2023 Zededa, Inc.
// SPDX-License-Identifier: Apache-2.0
package zedrouter
import (
"fmt"
"github.com/lf-edge/eve/pkg/pillar/nireconciler"
"github.com/lf-edge/eve/pkg/pillar/types"
"github.com/lf-edge/eve/pkg/pillar/utils/generics"
uuid "github.com/satori/go.uuid"
)
// Scan through existing AppNetworkStatus list to bring up any AppNetwork
// stuck in error state while contending for resources.
func (z *zedrouter) retryFailedAppNetworks() {
z.log.Functionf("retryFailedAppNetworks()")
pub := z.pubAppNetworkStatus
items := pub.GetAll()
for _, st := range items {
status := st.(types.AppNetworkStatus)
config := z.lookupAppNetworkConfig(status.Key())
if config == nil || !config.Activate || !status.HasError() {
continue
}
z.log.Functionf("retryFailedAppNetworks: retry AppNetworkConfigCreate(%s)",
status.Key())
// We wouldn't have even copied AppNetAdapter networks into status.
// This is as good as starting from scratch all over.
// App num that would have been allocated will be used this time also,
// since the app UUID does not change.
z.handleAppNetworkCreate(nil, status.Key(), *config)
}
}
// This function is called when AppNetworkConfig changes.
// In such case it can be necessary to update VIF description provided to NIStateCollector
// for all network instances that this app is or was connected to.
func (z *zedrouter) updateVIFsForStateCollecting(
prevAppConf, newAppConfig *types.AppNetworkConfig) {
// Determine the set of affected network instances.
var networks []uuid.UUID
if prevAppConf != nil {
for _, adapter := range prevAppConf.AppNetAdapterList {
networks = append(networks, adapter.Network)
}
}
if newAppConfig != nil {
for _, adapter := range newAppConfig.AppNetAdapterList {
networks = append(networks, adapter.Network)
}
}
networks = generics.FilterDuplicates(networks)
// Update state collecting for NIs that the app is or was connected to.
for _, network := range networks {
netConfig := z.lookupNetworkInstanceConfig(network.String())
if netConfig == nil {
z.log.Errorf("failed to get config for network instance %v "+
"(needed to update VIF arguments for state collecting)", network)
continue
}
_, vifs, err := z.getArgsForNIStateCollecting(network)
if err == nil {
err = z.niStateCollector.UpdateCollectingForNI(*netConfig, vifs)
}
if err != nil {
z.log.Error(err)
}
}
}
func (z *zedrouter) prepareConfigForVIFs(config types.AppNetworkConfig,
status *types.AppNetworkStatus) (vifs []nireconciler.AppVIF, err error) {
for i := range status.AppNetAdapterList {
adapterNum := i + 1
adapterStatus := &status.AppNetAdapterList[i]
netInstStatus := z.lookupNetworkInstanceStatus(adapterStatus.Network.String())
if netInstStatus == nil {
// Should be unreachable.
err := fmt.Errorf("missing network instance status for %s",
adapterStatus.Network.String())
z.log.Errorf("doActivateAppNetwork(%v/%v): %v",
config.UUIDandVersion.UUID, config.DisplayName, err)
z.addAppNetworkError(status, "doActivateAppNetwork", err)
return nil, err
}
adapterStatus.Bridge = netInstStatus.BridgeName
adapterStatus.BridgeMac = netInstStatus.BridgeMac
adapterStatus.BridgeIPAddr = netInstStatus.BridgeIPAddr
if adapterStatus.AppMacAddr != nil {
// User-configured static MAC address.
adapterStatus.Mac = adapterStatus.AppMacAddr
} else {
adapterStatus.Mac = z.generateAppMac(adapterNum, status, netInstStatus)
}
adapterStatus.HostName = config.Key()
guestIP, err := z.lookupOrAllocateIPv4ForVIF(
netInstStatus, *adapterStatus, status.UUIDandVersion.UUID)
if err != nil {
z.log.Errorf("doActivateAppNetwork(%v/%v): %v",
config.UUIDandVersion.UUID, config.DisplayName, err)
z.addAppNetworkError(status, "doActivateAppNetwork", err)
return nil, err
}
vifs = append(vifs, nireconciler.AppVIF{
App: status.UUIDandVersion.UUID,
NI: adapterStatus.Network,
NetAdapterName: adapterStatus.Name,
VIFNum: adapterNum,
GuestIfMAC: adapterStatus.Mac,
GuestIP: guestIP,
PodVIF: adapterStatus.PodVif,
})
}
return vifs, nil
}
func (z *zedrouter) doActivateAppNetwork(config types.AppNetworkConfig,
status *types.AppNetworkStatus) {
vifs, err := z.prepareConfigForVIFs(config, status)
if err != nil {
// Error already logged and added to status.
return
}
// Use NIReconciler to configure connection between the app and the network instance(s)
// inside the network stack.
appConnRecStatus, err := z.niReconciler.AddAppConn(
z.runCtx, config, status.AppNum, status.AppPod, vifs)
if err != nil {
err = fmt.Errorf("failed to activate application network: %v", err)
z.log.Errorf("doActivateAppNetwork(%v/%v): %v",
config.UUIDandVersion.UUID, config.DisplayName, err)
z.addAppNetworkError(status, "doActivateAppNetwork", err)
return
}
z.log.Functionf("Activated application network %s (%s)", status.UUIDandVersion.UUID,
status.DisplayName)
z.processAppConnReconcileStatus(appConnRecStatus, status)
// Update AppNetwork and NetworkInstance status.
status.Activated = true
z.publishAppNetworkStatus(status)
z.updateNIStatusAfterAppNetworkActivate(status)
// Update state data collecting to include this application.
z.checkAppContainerStatsCollecting(&config, status)
z.updateVIFsForStateCollecting(nil, &config)
}
func (z *zedrouter) updateNIStatusAfterAppNetworkActivate(status *types.AppNetworkStatus) {
for _, adapterStatus := range status.AppNetAdapterList {
netInstStatus := z.lookupNetworkInstanceStatus(adapterStatus.Network.String())
if netInstStatus == nil {
err := fmt.Errorf("missing network instance status for %s",
adapterStatus.Network.String())
z.log.Error(err)
continue
}
if netInstStatus.Type == types.NetworkInstanceTypeSwitch {
if adapterStatus.AccessVlanID <= 1 {
netInstStatus.NumTrunkPorts++
} else {
netInstStatus.VlanMap[adapterStatus.AccessVlanID]++
}
}
netInstStatus.AddVif(z.log, adapterStatus.Vif, adapterStatus.Mac,
status.UUIDandVersion.UUID)
netInstStatus.IPAssignments[adapterStatus.Mac.String()] =
types.AssignedAddrs{
IPv4Addr: adapterStatus.AllocatedIPv4Addr,
IPv6Addrs: adapterStatus.AllocatedIPv6List,
}
z.publishNetworkInstanceStatus(netInstStatus)
}
}
func (z *zedrouter) updateNIStatusAfterAppNetworkInactivate(
status *types.AppNetworkStatus) {
for _, adapterStatus := range status.AppNetAdapterList {
netInstStatus := z.lookupNetworkInstanceStatus(adapterStatus.Network.String())
if netInstStatus == nil {
err := fmt.Errorf("missing network instance status for %s",
adapterStatus.Network.String())
z.log.Error(err)
continue
}
if netInstStatus.Type == types.NetworkInstanceTypeSwitch {
if adapterStatus.AccessVlanID <= 1 {
netInstStatus.NumTrunkPorts--
} else {
netInstStatus.VlanMap[adapterStatus.AccessVlanID]--
}
}
netInstStatus.RemoveVif(z.log, adapterStatus.Vif)
delete(netInstStatus.IPAssignments, adapterStatus.Mac.String())
z.publishNetworkInstanceStatus(netInstStatus)
}
}
func (z *zedrouter) doCopyAppNetworkConfigToStatus(
config types.AppNetworkConfig,
status *types.AppNetworkStatus) {
ulcount := len(config.AppNetAdapterList)
prevNetStatus := status.AppNetAdapterList
status.AppNetAdapterList = make([]types.AppNetAdapterStatus, ulcount)
for i, netConfig := range config.AppNetAdapterList {
// Preserve previous VIF status unless it was moved to another network.
// Note that adding or removing VIF is not currently supported
// (such change would be rejected by config validation methods,
// see zedrouter/validation.go).
if i < len(prevNetStatus) && prevNetStatus[i].Network == netConfig.Network {
status.AppNetAdapterList[i] = prevNetStatus[i]
}
status.AppNetAdapterList[i].AppNetAdapterConfig = netConfig
}
}
// Called when a NetworkInstance is added or when an error is cleared
// Walk all AppNetworkStatus looking for AwaitNetworkInstance, then check
// if network UUID is there.
// Also check if error on network instance and propagate to app network.
func (z *zedrouter) checkAndRecreateAppNetworks(niID uuid.UUID) {
z.log.Functionf("checkAndRecreateAppNetworks(%v)", niID)
niStatus := z.lookupNetworkInstanceStatus(niID.String())
if niStatus == nil {
z.log.Warnf("checkAndRecreateAppNetworks(%v): status not available",
niID)
return
}
pub := z.pubAppNetworkStatus
items := pub.GetAll()
for _, st := range items {
appNetStatus := st.(types.AppNetworkStatus)
appNetConfig := z.lookupAppNetworkConfig(appNetStatus.Key())
if appNetConfig == nil {
z.log.Warnf("checkAndRecreateAppNetworks(%v): no config for %s",
niID, appNetStatus.DisplayName)
continue
}
if !appNetConfig.IsNetworkUsed(niStatus.UUID) {
continue
}
var awaitNetworkInstance bool
netInErrState, err := z.checkNetworkReferencesFromApp(*appNetConfig)
if err != nil {
awaitNetworkInstance = true
}
var changedErr bool
if netInErrState {
changedErr = z.addAppNetworkError(
&appNetStatus, "checkAndRecreateAppNetworks", err)
} else if appNetStatus.AwaitNetworkInstance && appNetStatus.HasError() {
appNetStatus.ClearError()
changedErr = true
}
if changedErr || appNetStatus.AwaitNetworkInstance != awaitNetworkInstance {
appNetStatus.AwaitNetworkInstance = awaitNetworkInstance
z.publishAppNetworkStatus(&appNetStatus)
}
if !appNetStatus.HasError() && !appNetStatus.AwaitNetworkInstance &&
appNetConfig.Activate && !appNetStatus.Activated {
z.doActivateAppNetwork(*appNetConfig, &appNetStatus)
}
z.log.Functionf("checkAndRecreateAppNetworks(%v) done for %s",
niID, appNetConfig.DisplayName)
}
}
func (z *zedrouter) doUpdateActivatedAppNetwork(oldConfig, newConfig types.AppNetworkConfig,
status *types.AppNetworkStatus) {
// To update status of connected network instances we can pretend
// that application network was deactivated and then re-activated.
// This approach simplifies the implementation quite a bit.
z.updateNIStatusAfterAppNetworkInactivate(status)
// Reloaded below, see reloadStatusOfAssignedIPs.
z.removeAssignedIPsFromAppNetStatus(status)
// Re-build config for application VIFs.
z.doCopyAppNetworkConfigToStatus(newConfig, status)
vifs, err := z.prepareConfigForVIFs(newConfig, status)
if err != nil {
// Error already logged and added to status.
return
}
// Update configuration inside the network stack.
appConnRecStatus, err := z.niReconciler.UpdateAppConn(
z.runCtx, newConfig, status.AppPod, vifs)
if err != nil {
err = fmt.Errorf("failed to update activated app network: %v", err)
z.log.Errorf("doUpdateActivatedAppNetwork(%v/%v): %v",
newConfig.UUIDandVersion.UUID, newConfig.DisplayName, err)
z.addAppNetworkError(status, "doUpdateActivatedAppNetwork", err)
return
}
z.log.Functionf("Updated activated application network %s (%s)",
newConfig.UUIDandVersion.UUID, newConfig.DisplayName)
// Update state data collecting parameters.
z.checkAppContainerStatsCollecting(&newConfig, status)
z.updateVIFsForStateCollecting(&oldConfig, &newConfig)
// Update app network status as well as status of connected network instances.
z.processAppConnReconcileStatus(appConnRecStatus, status)
z.reloadStatusOfAssignedIPs(status)
z.publishAppNetworkStatus(status)
z.updateNIStatusAfterAppNetworkActivate(status)
}
func (z *zedrouter) doInactivateAppNetwork(config types.AppNetworkConfig,
status *types.AppNetworkStatus) {
// Stop state data collecting for this application.
z.updateVIFsForStateCollecting(&config, nil)
z.checkAppContainerStatsCollecting(nil, status) // nil config to represent delete
// Use NIReconciler to un-configure connection between the app and the network instance(s)
// inside the network stack.
appConnRecStatus, err := z.niReconciler.DelAppConn(z.runCtx, config.UUIDandVersion.UUID)
if err != nil {
err = fmt.Errorf("failed to deactivate application network: %v", err)
z.log.Errorf("doInactivateAppNetwork(%v/%v): %v",
config.UUIDandVersion.UUID, config.DisplayName, err)
z.addAppNetworkError(status, "doInactivateAppNetwork", err)
return
}
z.log.Functionf("Deactivated application network %s (%s)", status.UUIDandVersion.UUID,
status.DisplayName)
z.processAppConnReconcileStatus(appConnRecStatus, status)
// Update AppNetwork and NetworkInstance status.
status.Activated = false
z.updateNIStatusAfterAppNetworkInactivate(status)
z.removeAssignedIPsFromAppNetStatus(status)
z.publishAppNetworkStatus(status)
}
// Check if any references to network instances have changed and potentially update
// allocated application interface numbers.
// Adds errors to status if there is a failure.
func (z *zedrouter) checkAppNetworkModifyAppIntfNums(config types.AppNetworkConfig,
status *types.AppNetworkStatus) {
// Check if any AppNetAdapter have changes to the Networks they use
for i := range config.AppNetAdapterList {
adapterConfig := &config.AppNetAdapterList[i]
adapterStatus := &status.AppNetAdapterList[i]
if adapterConfig.Network == adapterStatus.Network {
continue
}
z.log.Functionf(
"checkAppNetworkModifyAppIntfNums(%v) for %s: change from %s to %s",
config.UUIDandVersion, config.DisplayName,
adapterStatus.Network, adapterConfig.Network)
// update the reference to the network instance
err := z.doAppNetworkModifyAppIntfNum(
status.UUIDandVersion.UUID, adapterConfig, adapterStatus)
if err != nil {
err = fmt.Errorf("failed to modify appIntfNum: %v", err)
z.log.Errorf(
"checkAppNetworkModifyAppIntfNums(%v/%v): %v",
config.UUIDandVersion.UUID, config.DisplayName, err)
z.addAppNetworkError(status, "checkAppNetworkModifyAppIntfNums", err)
// Continue anyway...
}
}
}
// handle a change to the network UUID for one AppNetAdapterConfig.
// Assumes the caller has checked that such a change is present.
// Release the current appIntfNum and acquire appIntfNum on the new network instance.
func (z *zedrouter) doAppNetworkModifyAppIntfNum(appID uuid.UUID,
adapterConfig *types.AppNetAdapterConfig,
adapterStatus *types.AppNetAdapterStatus) error {
newNetworkID := adapterConfig.Network
oldNetworkID := adapterStatus.Network
newIfIdx := adapterConfig.IfIdx
oldIfIdx := adapterStatus.IfIdx
// Try to release the app number on the old network.
err := z.freeAppIntfNum(oldNetworkID, appID, oldIfIdx)
if err != nil {
z.log.Error(err)
// Continue anyway...
}
// Allocate an app number on the new network.
withStaticIP := adapterConfig.AppIPAddr != nil
err = z.allocateAppIntfNum(newNetworkID, appID, newIfIdx, withStaticIP)
if err != nil {
z.log.Error(err)
return err
}
// Did the freeAppIntfNum release any last reference from app to NI?
netstatus := z.lookupNetworkInstanceStatus(oldNetworkID.String())
if netstatus != nil {
if z.maybeDelOrInactivateNetworkInstance(netstatus) {
z.log.Functionf("Deleted/Inactivated NI %s as a result of moving app %s "+
"to another network %s", oldNetworkID, appID, newNetworkID)
}
}
return nil
}