Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch groups file is not created #49

Closed
rsarky opened this issue Apr 3, 2020 · 6 comments
Closed

Patch groups file is not created #49

rsarky opened this issue Apr 3, 2020 · 6 comments

Comments

@rsarky
Copy link
Contributor

rsarky commented Apr 3, 2020

The README mentions:

This will create a patch-groups file inside the resources directory of your project

However no patch-groups file is created.
Instead an mbox-resultfile is created.

@rralf
Copy link
Member

rralf commented Apr 3, 2020

Good point, that's typical legacy stuff... In mbox mode, the file is called mbox-result, in patch stack mode, it's called patch-groups...

I'm willing to accept patches that simply use a common filename for both modes, this would simplify things I guess.

I guess we can call it patch-groups for both cases.

@rsarky
Copy link
Contributor Author

rsarky commented Apr 3, 2020

Hmm acc to this seems like it is called pasta-results in patch stack mode?

@rralf
Copy link
Member

rralf commented Apr 3, 2020

Ah, you're right. Hmm. I guess patch-groups would be a more appropriate name. pasta-result could be anything...

Do you want to patch this? It would require to:

  • Patch the resources submodule, edit the default settings
  • patch pasta's configuration + forward resources submodule in one commit for consistency

Shouldn't be a big deal, though.

@rsarky
Copy link
Contributor Author

rsarky commented Apr 3, 2020

sure!

@rsarky
Copy link
Contributor Author

rsarky commented Apr 3, 2020

opened a PR in resources submodule: lfd/PaStA-resources#2

@rralf
Copy link
Member

rralf commented Apr 26, 2020

I guess we can close this one.

@rralf rralf closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants