Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include lfortran.wasm in this repo #12

Closed
certik opened this issue Aug 13, 2022 · 5 comments
Closed

Do not include lfortran.wasm in this repo #12

certik opened this issue Aug 13, 2022 · 5 comments

Comments

@certik
Copy link
Contributor

certik commented Aug 13, 2022

Right now, the lfortran.wasm is included in the repo: https://github.com/lfortran/lcompilers_frontend/blob/master/public/lfortran.wasm, but that will not scale as we start updating it on every LFortran commit, since it is 2.5MB each.

So we either need to build it automatically from the latest LFortran commit, or we need to download a prebuilt version from somewhere. Probably the latter option: LFortran's CI will build the wasm file, and push somewhere. Then this repository will download it. That way we know exactly what file is being used and can easily debug by hand if needed.

@Shaikh-Ubaid
Copy link
Member

Shaikh-Ubaid commented Aug 15, 2022

that will not scale as we start updating it on every LFortran commit, since it is 2.5MB each.

doubts:

  • Since the lfortran.wasm is of size around 2.5 MB (which seems to be (possibly) a constant or might increase slightly with more updates), please could someone possibly share/clarify how the current approach (of lfortran.wasm in master) might/would not scale?
  • Also, please, could someone possibly clarify what do we mean by scale here?

@certik
Copy link
Contributor Author

certik commented Aug 17, 2022

After discussing this, we decided to create https://github.com/lfortran/wasm_builds which should receive the automatic commits of lfortran.wasm (just like the tarballs repo). Then in this repo (https://github.com/lfortran/lcompilers_frontend) we should just download it at the CI, after triggering the CI with a webhook.

@Shaikh-Ubaid
Copy link
Member

Shaikh-Ubaid commented Aug 19, 2022

Update: With merging of #35, we are not including the lfortran.wasm and lfortran.js in this repository (and thus, they are also added to .gitignore). We currently download the lfortran.wasm and lfortran.js from https://github.com/lfortran/wasm_builds for a given specific commit of lfortran. As per discussion in #31, we are hoping to manually update/increment the commit Id/SHA to be used for fetching/downloading lfortran.wasm and lfortran.js from wasm_builds.

@Shaikh-Ubaid
Copy link
Member

Please, could someone possibly share if this issue is safe to close?

@certik
Copy link
Contributor Author

certik commented Aug 19, 2022

I think this is fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants