Add number, message and valid to response

lgaticaq · Jan 8, 2016 · adc580e · adc580e
1 parent def4289
commit adc580e
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -39,7 +39,10 @@ Result:
 
 ```js
 {
+  number: XXXXX, // a number
   balance: XXXXX, // a number
   date: XXXXX, // a date
+  message: XXXXX, // a string
+  valid: XXXXX // a boolean
 }
 ```
diff --git a/src/index.js b/src/index.js
@@ -11,11 +11,15 @@ const getBalance = (number, cb) => {
     json: true
   };
   rp(options).then((results) => {
-    const data = results[1];
-    if (!data.salida) deferred.reject(new Error('Not found'));
+    if (results.length === 0) deferred.reject(new Error('Not found'));
+    const balance = parseInt(results[1].saldo || 0, 10);
+    const date = results[1].fecha ? moment(results[1].fecha, 'DD\/MM\/YYYY HH:mm').toDate() : null;
     deferred.resolve({
-      balance: parseInt(data.saldo, 10),
-      date: moment(data.fecha, 'DD\/MM\/YYYY HH:mm').toDate()
+      number: parseInt(number, 10),
+      balance: balance,
+      date: date,
+      message: results[0].mensaje,
+      valid: results[1].salida
     });
   }).catch((err) => deferred.reject(err));
   deferred.promise.nodeify(cb);

diff --git a/test/test.js b/test/test.js
@@ -25,8 +25,11 @@ describe('bip', () => {
       lib(number, (err, data) => {
         expect(err).to.be.null;
         expect(data).to.be.a('object');
+        expect(data.number).to.be.a('number');
         expect(data.balance).to.be.a('number');
         expect(data.date).to.be.a('date');
+        expect(data.message).to.be.a('string');
+        expect(data.valid).to.be.a('boolean');
         done();
       });
     });
@@ -35,8 +38,11 @@ describe('bip', () => {
     it('should return a balance data (promise)', (done) => {
       lib(number).then((data) => {
         expect(data).to.be.a('object');
+        expect(data.number).to.be.a('number');
         expect(data.balance).to.be.a('number');
         expect(data.date).to.be.a('date');
+        expect(data.message).to.be.a('string');
+        expect(data.valid).to.be.a('boolean');
         done();
       }).fail((err) => {
         expect(err).to.be.null;
@@ -58,18 +64,27 @@ describe('bip', () => {
 
     it('should return a empty data (callback)', (done) => {
       lib(number, (err, data) => {
-        expect(err).to.eql(new Error('Not found'));
-        expect(data).to.be.undefined;
+        expect(err).to.be.null;
+        expect(data).to.be.a('object');
+        expect(data.number).to.be.a('number');
+        expect(data.balance).to.eql(0);
+        expect(data.date).to.eql(null);
+        expect(data.message).to.be.a('string');
+        expect(data.valid).to.eql(false);
         done();
       });
     });
 
     it('should return a empty data (promise)', (done) => {
       lib(number).then((data) => {
-        expect(data).to.be.undefined;
+        expect(data.number).to.be.a('number');
+        expect(data.balance).to.eql(0);
+        expect(data.date).to.eql(null);
+        expect(data.message).to.be.a('string');
+        expect(data.valid).to.eql(false);
         done();
       }).fail((err) => {
-        expect(err).to.eql(new Error('Not found'));
+        expect(err).to.be.null;
         done();
       });
     });