Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter ppm to consensusSpectrum and meanMzInts #373

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Conversation

jorainer
Copy link
Collaborator

I've added the parameter ppm to the consensusSpectrum and meanMzInts functions that allow to group mass peaks from different spectra into the same combined mass peak in a m/z dependent manner (i.e. if their difference in m/z values is smaller than ppm of the m/z of the peaks). This will complement the grouping based on a fixed value (parameter mzd).

In case you are wondering, I did also remove some non-unicode characters in comments as they were breaking devtools::document().

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #373 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   71.22%   71.23%   +<.01%     
==========================================
  Files          82       82              
  Lines        8237     8239       +2     
==========================================
+ Hits         5867     5869       +2     
  Misses       2370     2370
Impacted Files Coverage Δ
R/DataClasses.R 75% <ø> (ø) ⬆️
R/functions-Spectrum.R 88.36% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be3d77...6036f88. Read the comment docs.

@lgatto lgatto merged commit 626bd2e into master Oct 26, 2018
@lgatto
Copy link
Owner

lgatto commented Oct 26, 2018

Also on Bioc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants