-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mztabm #502
Feature/mztabm #502
Conversation
Could you please send a PR per requested change.
|
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 71.80% 71.94% +0.14%
==========================================
Files 82 82
Lines 8225 8274 +49
==========================================
+ Hits 5906 5953 +47
- Misses 2319 2321 +2
Continue to review full report at Codecov.
|
@@ -11,7 +11,7 @@ test_that("MzTab creation and accessors", { | |||
expect_null(show(xx)) | |||
## Accessors | |||
expect_is(metadata(xx), "list") | |||
expect_identical(length(metadata(xx)), 64L) | |||
expect_identical(length(metadata(xx)), 65L) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that the previous implementation without headers=FALSE
swallowed the first line of the MTD section. After fixing that there is one more metadata line.
Are there more PRs to come, or should I push to Bioconductor now? |
There are no imminent PRs. What's left is a decision about the dimensionality of things. |
Pushed to Bioc. |
This PR adds
Points for discussion:
check.names=FALSE
change ?write.mzTab()
as method OK ?Yours, Steffen