Refactor getAbi #12
Merged
Refactor getAbi #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(will fix this) |
|
@juliangruber Are you still interested in finishing up this PR? 😄 |
|
yes, will do! |
Awesome thanks! |
lgeiger
force-pushed
the
refactor/get-abi
branch
from
fb2b87b
to
7cab3a8
Compare
|
@juliangruber I rebased your PR. This should now be good to go. One minor draw back is the slightly increased packages size due to the inclusion of |
|
Thank you so much, LVGTM! |
lgeiger
reviewed
Sep 5, 2017
| @@ -61,7 +61,6 @@ test('getAbi calculates correct Node ABI', function (t) { | |||
|
|
|||
| test('getAbi calculates correct Electron ABI', function (t) { | |||
| t.throws(function () { getAbi(undefined, 'electron') }) | |||
| t.throws(function () { getAbi('7.2.0', 'electron') }) | |||
There was a problem hiding this comment.
Just realized that this changes behavior:
node-abi wouldn't throw anymore if the version isn't supported yet. This could lead to strange behaviors since node-abi would just return the wrong ABI instead. Let me fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is based on #11, so ignore "add missing abi versions to targets")
Yay for less maintenance :)