Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angle calculation #98

Open
BergmuellerNiklas opened this issue Jul 6, 2020 · 0 comments
Open

Fix angle calculation #98

BergmuellerNiklas opened this issue Jul 6, 2020 · 0 comments
Assignees
Labels
backlog Issues that are unlikely to be finished in the MVP bug Something isn't working

Comments

@BergmuellerNiklas
Copy link
Collaborator

Current problem: when we calculate the angle, we cannot measure anything over 180 degrees, since the formula we are using only supports the inner angle.

Possible solution: calculate a linear function through coordinates of hip and knee and then see if ankle coordinates lie on this linear function or further left/right. If this is the case, we know that the degree is larger than 180. And can use the outer angle degree or transform the inner angle to the outer angle.
E.g.
real value: 190 degrees
currently shown: 170 degrees
If we know that is has to be more than 180 degree (by checking the linear function), we can simply calculate (180-current degree) + 180

See here.
https://www.youtube.com/watch?v=fTVurY4Y0Wo

@BergmuellerNiklas BergmuellerNiklas self-assigned this Jul 6, 2020
@BergmuellerNiklas BergmuellerNiklas added backlog Issues that are unlikely to be finished in the MVP bug Something isn't working labels Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues that are unlikely to be finished in the MVP bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant