Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable Sample #15

Closed
wants to merge 2 commits into from
Closed

Immutable Sample #15

wants to merge 2 commits into from

Conversation

treyshaffer
Copy link

As the Sample is being treated as an immutable struct, you could use a Builder to make it immutable and then have instance data publicly accessible. It seems this class is just being treated as a container for data.

Note: This will change instantiation and data accessing.

As the Sample is being treated as an immutable struct, you could use a Builder to make it immutable and then have instance data publicly accessible. It seems this class is just being treated as a container for data.

Note: This will change instantiation and data accessing.
@lgvalle
Copy link
Owner

lgvalle commented Sep 25, 2015

Hi @BlurryZombie I appreciate your effort in this PR but I prefer not to merge it.
I understand this change would make the code base of Sample object better but the main target of this project is illustrate how to do animations. So in order to keep things simple and easy to understand I don't mind scarifying code correctness.

That said, if you like to contribute with more Android animation examples I'm very happy to add those.

@lgvalle lgvalle closed this Sep 25, 2015
@treyshaffer
Copy link
Author

Yeah, I understand. thanks for the reply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants