stringifying xhr error response #2804
Open
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boazblake
requested review from
dead-claudia and
StephanHoyer
as code owners
Bumps [terser](https://github.com/terser/terser) from 4.3.4 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
boazblake
force-pushed
the
stringify-xhr-error-response
branch
from
31e6fa1
to
6edfeb7
Compare
boazblake
force-pushed
the
stringify-xhr-error-response
branch
from
d1b4c45
to
10922d7
Compare
|
Not accepting this unless you can figure out a way to do it for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an XHR error response is returned with responseType set to 'json' the error reponse is not handled correctly.
Description
When the responseText is type JSON the response is still assigned to the new Error which is expecting a string.
Motivation and Context
This PR is an attempt to address #2802
How Has This Been Tested?
I ran
yarn test request/tests/test-request.jsI saw a bunch of warnings and errors that were unrelated I believe.
Types of changes
Checklist:
docs/changelog.md