m.route( pathString, queryObject) creates new param keys

[barneycarroll]

When assigning strings to keys in the queryObject paramter, my assumption is that an extant param with that key would be replaced, but instead a new key=value pair is appended to the route. In the case where only the last value is read, this is just an issue of ambiguous cruft, but for URI APIs that use multiple key=value pairs to represent list items, this is a functional bug.

[lhorie]

Can you provide a jsfiddle illustrating the issue?

[eddyystop]

Mithril may have a design issue similar to one Node's Express had: http://techblog.netflix.com/2014/11/nodejs-in-flames.html?utm_source=nodeweekly&utm_medium=email

The guts of the article are the 3 paragraphs above "When the Smoke Cleared"

[barneycarroll]

@eddyystop actually Mithril avoids that issue by forcing you to declare routes in one place — you can't add a route node, you can only specify the whole route map in one go.

What I'm talking about is a case where I'm trying to modify a query param with a function that's agnostic of the wider route context:

// location: 'http://example.com?foo=bar'
m.route( m.route(), { foo : 'baz' } );
// location: 'http://example.com?foo=bar&foo=baz'

[barneycarroll]

Here we go. In this reduced case a contrived route hash has a single endpoint, /. The view renders an element which displays the route and, onclick, invokes the full redirection signature of m.route. By my expectation, it should start as /, become /?foo=bar onclick, and stay that way no matter how many times it's clicked. Instead, we quickly end up with a huge string of foo=bar&foo=bar&foo=bar etc.

The snippet, to avoid over-reliance on jsfiddle:

m.route( document.body, '/', {
    '/' : {
        controller : function(){},
        view       : function(){
            return m( 'pre', {
                onclick : function(){
                    m.route( m.route(), {
                        foo : 'bar'
                    } );
                }
            }, m.route() );
        }
    }
} );

[lhorie]

Ok yep, this is a bug. Thanks.

[lhorie]

Fixed in origin/next

[barneycarroll]

Nice one Leo!