Single component redraw fix #743
Conversation
Applied @jonahx ’s single component redraw patch on the current master.
| for (var i = 0; i < controllers.length; i++) { | ||
| var controller = controllers[i]; | ||
| if (isFunction(controller.redrawSelf)) { | ||
| controller.redrawSelf = (function(ctrl,view) { |
There was a problem hiding this comment.
Js lint error clean up Ref : https://jslinterrors.com/dont-make-functions-within-a-loop
|
@Naddiseo Thanks for pointing it out. |
| var views = [], controllers = []; | ||
| data = markViews(data, cached, views, controllers); | ||
| if (!data.tag && controllers.length) throw new Error("Component template must return a virtual element, not an array, string, etc."); | ||
| if (!data.tag && controllers.length) throw new Error("Component template must return a virtual element, not an array, string, etc."); |
|
How does Is there a way to merge the for-loop with another for-loop called indirectly earlier on in the function? |
Removed trailing whitespace and added space after comma
Refer @jonahx 's codepen for more details. |
|
@dhinesh03 please, consider adding a documentation for |
Necessary config functions has been invoked after self-redraw.
|
@avesus Busy with my work, Will add doc soon. |
configs - array not initialized while self redraw issue fixed
|
@dhinesh03 I'd definitely like to see something like this in a future release. What is the status of this pr? |
|
Closing for now (cleaning up old PRs). Please open a new issue or PR if you want this to be fixed/added/implemented. |
|
Closing it and reopening it seems like it makes things messier, to me. I'm still interested in this, and based on thread comments no reason to think other people's interest has changed. |
|
You want to run a diff for yourself? It has tons of merge conflicts, and is best just redone. |
|
I’m happy to redo it if there are any plans to merge it. If not, On 10 Dec 2015, at 19:18, Isiah Meadows wrote:
|
|
If you clean this up (trust me in that you'd have to deal with a massive On Thu, Dec 10, 2015, 21:07 Jonah notifications@github.com wrote:
|
|
Any plans to implement and merge it? It is a great feature for some applications. My application has many components working at the same time, and sometimes this feature would be good. |
Applied single component redraw patch on the current master.