Height Property

[raducretu]

Hey there,

Congrats for your plugin! You might consider setting the min-height param and not the height as it will allow more flexibility; just a quick hint :)

Radu

[liabru]

Thanks for the suggestion, but this may actually break the result for some peoples use cases!
It may be something worth adding as an option though, I'll try it out.

The only way it would really work fully is if matchHeight could update automatically when items change size. This would be getting into element query territory though.

[maximelebreton]

+1

[liabru]

Can either of you show me a jsfiddle with a case where you need this ability? Thanks

[raducretu]

Hi, it's a little hard, to show but i will describe why. If you use it on responsive layouts, then height can create some huge gaps or try to force the content to fit in a smaller box that the content is on mobile. Please let me know if it makes sense.

[smdksu]

I also vote for some flexibility and/or updating option. My use case - I'm using this for equal height content and sidebar columns. If I use any sort of collapsable tabs that expand in the content area that will break the layout as the height is set.

[liabru]

@smdksu if I add an option to use min-height rather than height, would this solve your issue?

[smdksu]

After playing around with some more options my issue seems to be more complicated. Min-height helps the content area that gets expanded but leaves the other columns needed to be resized. In most use cases this is probably fine but since I am using it on a content area and sidebar it doesn't work visually for the sidebar to have a gap.

You can call the resize update function but you have to wait for the content to fully expanded, and if there is any animation to the expansion then there is a big delay before everything lines back up. This is especially jarring on collapse since columns can overlap before resizing.

I'm now thinking that the issue is too complex to have this sort of solution work. Which is fine, the plugin does a great job at what it already does.

[liabru]

You can call the resize update function but you have to wait for the content to fully expanded, and if there is any animation to the expansion then there is a big delay before everything lines back up.

Exactly, animation or any kind of dynamic sizing isn't supported by the nature of the plugin sadly.

I'm now thinking that the issue is too complex to have this sort of solution work. Which is fine, the plugin does a great job at what it already does.

This is the conclusion I came to as well when I was looking at this sort of thing, they only really work for very specific use cases.

So unless someone provides a jsfiddle with a good example, I still don't see a concrete need or feature here that can be implemented?

[tomagladiator]

Hello, I have the situation :)
http://jsfiddle.net/twnevn8k/2/

For this case, an option could be useful.

[liabru]

@tomagladiator not sure why you need matchHeight for that?

Either way, just calling $.fn.matchHeight._update(); works fine here.

[tomagladiator]

Thanks,
@liabru in fact my exemple is too simple.

In reality I have a huge tentacular forms with a lot of animated slideDown.

This fiddle is more closer to my case : http://jsfiddle.net/twnevn8k/3/
(because slideToggle) :)

[liabru]

So again, your problem is because of animation? As animation isn't supported...

[tomagladiator]

indeed. -_-'
Sorry, I just saw this: animation not supported

So, I will add a custom script to change your height to min-height.

[liabru]

@kiballion @maximelebreton @smdksu @tomagladiator

I have added support for min-height in the latest master version:
https://github.com/liabru/jquery-match-height/blob/master/jquery.matchHeight.js

Usage is like so:

$('.item').matchHeight({ property: 'min-height' });

I'm still not certain this will solve the root cause of most of your issues here, but please try it and tell me if you have any success. Thanks.

[Akrion]

Hi, I am using the 0.5.2 version and the above fix does not seem to work. Was the min-height released as part of the 0.5.2? Thanks again for your work and for sharing.

[liabru]

This feature is currently only in the latest master build so please use that for the time being, thanks.

[Akrion]

Thanks. Will do.

Sent from my iPhone

On Mar 26, 2015, at 5:12 PM, Liam notifications@github.com wrote:

This feature is currently only in the latest master build so please use that for the time being, thanks.

—
Reply to this email directly or view it on GitHub.