Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display: block #7

Closed
allybee opened this issue Apr 30, 2014 · 8 comments
Closed

display: block #7

allybee opened this issue Apr 30, 2014 · 8 comments

Comments

@allybee
Copy link

allybee commented Apr 30, 2014

This works really well except if used on an element that utilizes the css "display" attribute. e.g., display: table; Since the display attribute gets overwritten by the javascript, it breaks the design (unless using !important). Perhaps an optional setting variable could be created for the display attribute?

@liabru
Copy link
Owner

liabru commented May 1, 2014

This is a good idea - I'll see if I can make it preserve display where possible and maybe an option to force a certain display value - cheers

@liabru
Copy link
Owner

liabru commented May 1, 2014

I've now added this to the latest build.

Basically, it doesn't force display:block; anymore so hopefully that solves your issue, can you confirm?

@allybee
Copy link
Author

allybee commented May 2, 2014

Implemented and tested – confirmed working! Thank you.

@liabru
Copy link
Owner

liabru commented May 2, 2014

Great, thanks for logging the issue

@liabru liabru closed this as completed May 2, 2014
@lkraav
Copy link

lkraav commented Jun 10, 2014

I was wondering why this wasn't working for me when my elements are display: inline-block Turns out apparently changelog says 0.5.1 already includes this patch, but the actual 0.5.1 release tag points to an earlier state. Confusion :/

@liabru
Copy link
Owner

liabru commented Jun 10, 2014

@lkraav my bad! I never got around to updating the release - I've now pushed 0.5.2 which should mean the latest tag is now up to date.

Are you still having issues using inline-block?

@jerseycheese
Copy link

He might not be, but I am. Unordered list items w/ display: inline-block do not get matching heights applied here.

@liabru
Copy link
Owner

liabru commented Jun 29, 2014

@jerseycheese can you provide an example jsfiddle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants