Do not trigger window resizing work if no change in dimensions #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redundant dpiScale removed from GUI; dpiScale used to calculate desired size in pixels.
Signed-off-by: Max Risuhin <risuhin.max@gmail.com>
maxhora
changed the title
maxhora
changed the title
liamg
previously approved these changes
Jan 24, 2019
liamg
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extra triggering of window resizing on restoring from iconified state causes content rendering glitches described in #145
gui.appliedWidth and gui.appliedHeight introduced to keep last applied window width/height and avoid unnecessary resize of terminal content.
dpiScale is removed from calculation of actual window sizes and used once on initial calculation.
Changelist doesn't fix resize logic to avoid producing rendering glitches.
Fixes #145
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration: