#308 remove warnings and handling of directory variable

betcode-org · Jul 27, 2020 · c39d91e · c39d91e
1 parent 4870aab
commit c39d91e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 36 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -8,6 +8,7 @@ Release History
 
 **Improvements**
 
+- #308 remove directory warnings / handling (breaking change)
 - #318 include streaming_update in generator
 
 **Bug Fixes**

diff --git a/betfairlightweight/endpoints/streaming.py b/betfairlightweight/endpoints/streaming.py
@@ -53,7 +53,7 @@ def create_stream(
 
     @staticmethod
     def create_historical_stream(
-        file_path: str = None, listener: BaseListener = None, **kwargs
+        file_path: str = None, listener: BaseListener = None
     ) -> HistoricalStream:
         """
         Uses streaming listener/cache to parse betfair
@@ -65,18 +65,12 @@ def create_historical_stream(
 
         :rtype: HistoricalStream
         """
-        if file_path is None and kwargs.get("directory"):
-            warnings.warn(
-                "directory is deprecated; use file_path", DeprecationWarning,
-            )
-            file_path = kwargs.get("directory")
-
         listener = listener if listener else BaseListener()
         return HistoricalStream(file_path, listener)
 
     @staticmethod
     def create_historical_generator_stream(
-        file_path: str = None, listener: BaseListener = None, **kwargs
+        file_path: str = None, listener: BaseListener = None
     ) -> HistoricalGeneratorStream:
         """
         Uses generator listener/cache to parse betfair
@@ -88,11 +82,5 @@ def create_historical_generator_stream(
 
         :rtype: HistoricalGeneratorStream
         """
-        if file_path is None and kwargs.get("directory"):
-            warnings.warn(
-                "directory is deprecated; use file_path", DeprecationWarning,
-            )
-            file_path = kwargs.get("directory")
-
         listener = listener if listener else StreamListener()
         return HistoricalGeneratorStream(file_path, listener)
diff --git a/tests/unit/test_streamingendpoint.py b/tests/unit/test_streamingendpoint.py
@@ -44,25 +44,3 @@ def test_create_historical_generator_stream(self, mock_stream):
             file_path=file_path, listener=listener
         )
         mock_stream.assert_called_with(file_path, listener)
-
-    @mock.patch("betfairlightweight.endpoints.streaming.HistoricalStream")
-    def test_create_historical_stream_with_directory(self, mock_stream):
-        file_path = "test"
-        listener = mock.Mock()
-
-        with self.assertWarns(DeprecationWarning):
-            self.streaming.create_historical_stream(
-                directory=file_path, listener=listener
-            )
-            mock_stream.assert_called_with(file_path, listener)
-
-    @mock.patch("betfairlightweight.endpoints.streaming.HistoricalGeneratorStream")
-    def test_create_historical_generator_stream_with_directory(self, mock_stream):
-        file_path = "test"
-        listener = mock.Mock()
-
-        with self.assertWarns(DeprecationWarning):
-            self.streaming.create_historical_generator_stream(
-                directory=file_path, listener=listener
-            )
-            mock_stream.assert_called_with(file_path, listener)