Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ability to add additional coords to Edges via mouse click #71

Open
liamross opened this issue Jul 25, 2018 · 2 comments · May be fixed by #89
Open

Implement ability to add additional coords to Edges via mouse click #71

liamross opened this issue Jul 25, 2018 · 2 comments · May be fixed by #89
Assignees
@liamross
Labels
🚨 critical Top priority to fix or implement 📦 feature New feature or request
Projects
Major Release

Comments

@liamross
Copy link
Owner

Problem

  1. Unable to adjust routing of Edges

Solution

  1. Add ability for click-to-add points along Edges

Alternatives

  1. None worth mentioning

Additional context

  1. Add a second shape behind Edge that is thicker and picks up mouse inputs
@liamross liamross self-assigned this Jul 25, 2018
@liamross liamross added this to To do in Major Release via automation Jul 25, 2018
@liamross liamross added the 📦 feature New feature or request label Jul 31, 2018
@liamross liamross added 🚨 critical Top priority to fix or implement and removed 🏭 release: major labels Aug 29, 2018
@liamross
Copy link
Owner Author

Implement the following section of the psiagram-plugin-mouse-events package

psiagram/packages/psiagram-plugin-mouse-events/src/plugin/MouseEvents.ts

Lines 191 to 210 in ce3faac

private _handleEdgeMouseDown(evt: MouseEvent, id: string): void {
// TODO: implement.
console.log('mouseDown on Edge');
}
private _handleEdgeMouseMove = (evt: MouseEvent): void => {
// TODO: implement.
};
private _handleEdgeMouseUp = (): void => {
// TODO: implement.
};
private _handlePaperMouseDown(evt: MouseEvent, id: string): void {
// TODO: implement.
// Deselect any selected items.
if (this._paperInstance) {
this._paperInstance.updateActiveItem();
}
}

@liamross
Copy link
Owner Author

liamross commented Jan 2, 2019

Work is in progress at #89

@liamross liamross linked a pull request Jan 24, 2019 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamross liamross

Labels
🚨 critical Top priority to fix or implement 📦 feature New feature or request
Projects
Major Release
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Add edge points liamross/psiagram
1 participant
@liamross