-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLEASE REMOVE THE ADVICE TO USE PGX FROM YOUR PAGE #1022
Comments
That's not fair...
// IsErrTimeout reports whether the given "err" was caused by a timeout;
// context.Canceled, context.DeadlineExceeded or a network timeout.
func IsErrTimeout(err error) bool {
if IsErrCanceled(err) {
return true
}
var netErr net.Error
return errors.As(err, &netErr) && netErr.Timeout()
}
// IsErrCanceled reports whether the given "err" was caused by a
// context.Canceled or context.DeadlineExceeded timeout.
func IsErrCanceled(err error) bool {
return errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded)
}
Both pgx and pq are great libraries, I used pq at first but now I am using pgx on a production-level product with thousand of calls per second, works like a charm (both of them did). Cheers and have fun! |
If the PGX maintainers acknowledged "PGX statements can't handle float64" If the PGX Maintainers acknowledged the pool issues and limitations Where did you come up with your conclusion? You misleading people by comments does not relate to the issue being raised here. Please try to understand and study the 4 points I mentioned above, please try to make relevant comments worth reading mate. Thank you, |
@uwauwa please try to be more civil, @kataras took their time trying to come up with a helpful response and at least the first response looks reasonable. I can't comment on the float64 point since I don't know about them. Having that said, I looked briefly in lib/pq and pgx connection error handling since we ran into a production issue with it. Based on that I will try to answer your questions regarding that aspect:
Perhaps you ran into a connection limit? pgxpool defaults to a maximum of four connections (or the number of CPUs, whichever is larger):
I have not looked closely at how to use pgx in its best capacity so cannot make recommendations there, but those are questions to be filed with the pgx community. |
Hi, Is there any progress here please? @uwauwa can you please provide more information? We have similar situation where we use this lib heavily in our agency. Thank you, |
for case 2) i raised an issue with pgx jackc/pgx#1541 |
PLEASE REMOVE THE ADVICE TO USE PGX FROM YOUR PAGE
jackc/pgx#905 (comment)
we have migrated 250 instances web applications from lib/pq to pgx based on the performance promises
we had to revert back to lib/pq.
we believe this is not production ready and the performance statement should be amended
ubunut 20/aws ec2, postgresql12.5 /aws rds, go1.5,
gobwas/ws latest
lib/pq latest
pgx latest
The text was updated successfully, but these errors were encountered: