al_build_menu segfault

[SiegeLord]

See https://www.allegro.cc/forums/thread/616194 for details.

It looks like the recursion isn't coded quite correctly, the function always returns 1 past the last pointer read, which causes the outer loop to read 1 past the final entry for nested menus.

[SiegeLord]

This is a PEBCAK, although it's sad that we have to segfault. You always need two trailing ALLEGRO_END_OF_MENU if you have nested menus as per the documentation.

[fatcerberus]

This makes perfect sense to me. One ALLEGRO_END_OF_MENU for each nesting level, just like you need to match brackets in code. If we could fix the segfault it would be great, but I guess if that's too difficult it's not worth going to the trouble.