Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency/Consolidation in Parsing Methods #176

Open
pbauman opened this issue Feb 3, 2016 · 1 comment
Open

Consistency/Consolidation in Parsing Methods #176

pbauman opened this issue Feb 3, 2016 · 1 comment

Comments

@pbauman
Copy link
Member

pbauman commented Feb 3, 2016

Some methods we take a pointer to a parser that's already created (e.g. ChemicalMixture constructor). Others, we don't give that option and construct the parser internally (e.g. `read_reaction_set_data1). It would be nice for the user to instantiate one parser object and use it everywhere, if appropriate.

@pbauman
Copy link
Member Author

pbauman commented Jun 26, 2018

There are some methods that live in global namespace, e.g. read_reaction_set_data, that should be in ParserBase and then calls methods that can be implemented in subclasses. This is once example. We definitely want to consolidate all these because the parsing is spread out everywhere making it really hard to follow.

@pbauman pbauman changed the title Consistency in Parsing Methods Consistency/Consolidation in Parsing Methods Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant