Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli support #1238

Closed
stokito opened this issue Aug 30, 2019 · 4 comments
Closed

Brotli support #1238

stokito opened this issue Aug 30, 2019 · 4 comments

Comments

@stokito
Copy link

stokito commented Aug 30, 2019

Do you have any plans to add a support of the Brotli compression algorithm?

@kientzle
Copy link
Contributor

kientzle commented Sep 1, 2019

Brotli looks like it might be worth adding: There's an RFC for it and I see it's already supported by some tools.

Key requirements:

  • Must have a well-designed initial signature for automatic detection.
  • Must compress/decompress a stream.
  • Should have a well-designed API (zlib's API is well done; most compression libraries seem to be copying it)

@stokito
Copy link
Author

stokito commented Sep 2, 2019

Unfortunately at the moment Brotli doesn't have a magic signature google/brotli#727
Is this a strict requirement?
It would be great to have the Brotli support in libarchive because it is used by KDE Ark archive manager and to make adoption of Brotli wider we need all desktop environments to support it.
Brotli is already supported by GNOME File Roller and MATE Engrampa.

@kientzle
Copy link
Contributor

Without a magic signature, libarchive cannot automatically recognize the file type, so it cannot automatically decompress. (Libarchive does not consider the file name, only the contents.)

@kientzle
Copy link
Contributor

I don't think we can support brotli if it lacks a magic signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants