Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to detect that encryption is not supported #1662

Open
ondrejholy opened this issue Feb 7, 2022 · 0 comments
Open

Add a way to detect that encryption is not supported #1662

ondrejholy opened this issue Feb 7, 2022 · 0 comments

Comments

@ondrejholy
Copy link
Contributor

The password is requested by gnome-autoar, when archive_entry_is_encrypted returns TRUE. This is fine for ZIP, but not for RAR/7ZIP, or perhaps some other formats, where the subsequent archive_read_data_block (or archive_read_next_header in the case of archive_entry_is_metadata_encrypted) returns an error that it is not supported. I would suggest returning FALSE from archive_entry_is_encrypted resp. archive_entry_is_metadata_encrypted when the encryption is not supported or adding some new API to determine this situation before asking a user for a password. Or is there already a way to achieve this somehow?

Related to https://gitlab.gnome.org/GNOME/gnome-autoar/-/merge_requests/34 and #1374.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant