Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document subtitle switching #38

Closed
cobarx opened this issue Dec 28, 2018 · 3 comments
Closed

Document subtitle switching #38

cobarx opened this issue Dec 28, 2018 · 3 comments

Comments

@cobarx
Copy link
Collaborator

cobarx commented Dec 28, 2018

PR #31 added support for switching subtitles without re-initializing the engine. We should get the API for this documented in the README. @YePpHa Would you mind putting together a quick PR for this?
@cobarx cobarx assigned cobarx and unassigned cobarx Dec 28, 2018
@cobarx
Copy link
Collaborator Author

cobarx commented Mar 2, 2019

@YePpHa Quick reminder to document this if you get a chance.

@YePpHa
Copy link
Contributor

YePpHa commented Mar 2, 2019

Ahh yeah. Sorry about that. I forgot all about this. I will try to get it done soon.

@YePpHa YePpHa mentioned this issue Mar 2, 2019
Merged
@cobarx
Copy link
Collaborator Author

cobarx commented May 8, 2019

Thanks @YePpHa, these enhancements to the docs are great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@YePpHa @cobarx @TFSThiagoBR98