Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering: VSFilter/GDI draws underline/strikethrough using clockwise-wound rectangles #686

Open
rcombs opened this issue Mar 11, 2023 · 0 comments

Comments

@rcombs
Copy link
Member

rcombs commented Mar 11, 2023

Screenshots

VSFilter examples:

(Gandhi Sans)
image

(Gandhi Sans on top, Arial below)
image

Description of the issue

We can see here that the portions of the strikethrough line that overlap with text are inverted to transparent. This is because GDI implements underline and strikethrough by adding clockwise-wound boxes to the glyphs, meaning that counterclockwise-wound fonts (like Gandhi Sans) will generally have a 0 net winding count at those overlap points.

libass version

218dace

Is it a regression?

Nope

ASS Sample

{\fnGandhi Sans\u1\s1}TEST TEXT

https://www.fontsquirrel.com/fonts/gandhi-sans

Special Fonts

I uploaded or linked to the required font

System Information

(Not OS-specific)

Log

N/A

Additional info

I honestly don't think we need to emulate this behavior; I just think we should document it somewhere.

@rcombs rcombs changed the title Rendering: VSFilter/GDI draws underline/strikethrough using counterclockwise-wound rectangles Rendering: VSFilter/GDI draws underline/strikethrough using clockwise-wound rectangles Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant