Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of activity types #136

Open
nickvergessen opened this issue Aug 29, 2015 · 1 comment
Open

Reduce the number of activity types #136

nickvergessen opened this issue Aug 29, 2015 · 1 comment

Comments

@nickvergessen
Copy link

nickvergessen commented Aug 29, 2015

https://github.com/libasys/calendarplus/blob/master/lib/activity.php#L57-L67

11 types is way too much, I think most users don't change them individually, so my suggestion would be:

        self::TYPE_SHARED_EVENT => $l->t('An <strong>event or todo</strong> has been <strong>modified</strong> on a shared Calendar'),
        self::TYPE_SHARE => $l->t('An <strong>event, todo or calendar</strong> has been <strong>shared/unshared</strong>'),
        self::TYPE_EVENT => $l->t('An <strong>event or todo</strong> has been <strong>deleted</strong>'),
        self::TYPE_CALENDAR => $l->t('A <strong>calendar</strong> has been <strong>modified</strong>'),

whereby modified means: created, edited or deleted.

@jancborchardt

Related to owncloud/activity#356

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26298703-reduce-the-number-of-activity-types?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19394737&utm_medium=issues&utm_source=github).
@farson2003
Copy link

Please correct the spelling: In english it should be "An event..." and not "A event".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants