Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fetch_block_locator from spin lock. #368

Closed
evoskuil opened this issue Apr 23, 2017 · 2 comments
Closed

Move fetch_block_locator from spin lock. #368

evoskuil opened this issue Apr 23, 2017 · 2 comments
Labels
enhancement

Comments

@evoskuil
Copy link
Member

No description provided.

@evoskuil
Copy link
Member Author

It may be sufficient to just not guard this, assuming that primary issues would be of missing a top block, which is a non-issue due to subsequent filtering, or missing a reorg, where we have the wrong set of blocks. But in this case the peer will either agree or won't, and we will correct on the next attempt in any case.

@evoskuil
Copy link
Member Author

This is equivalent to the preceding implementation, since it relied on a set of heights and neither a guarantee of top nor lack of a reorg. Implemented in #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evoskuil