watch-address uses 100% of the CPU

[ggutoski]

Running on testnet build with server obelisk-testnet.airbitz.co:9091. Wait time bumped up to 5000ms from 2000ms but otherwise all defaults are preserved. The command still reports new transactions to the watched address, so it's not hung---just hogging CPU.

Edit: The rest of this issue has been cut and moved to a new separate Issue 154

[evoskuil]

Hi @ggutoski , could you give me the platform info and how you are measuring CPU usage?

[ggutoski]

Platform:
ubuntu 14.04 (running as a guest on VMware Player with Windows 7 host)
Intel Core i7-3520M CPU @ 2.90GHz, 64 bit

I measure CPU usage using System Viewer. (No laughing.) Screenshot below. bx eats up as much CPU as the system will let it---88% in this image.

[evoskuil]

The level seems high on Windows as well, at about 20% average CPU utilization on my dev machine, about the same as compilation on any given thread in VS 2013.

[pmienk]

Looking at the code, obelisk_client.poll_until_termination takes a timeout parameter which when not specified (as in watch-address) defaults to 0. Presumably you're seeing a busy-wait behavior due to the default. What would be a 'sane' default?

[evoskuil]

Fixed in #155

[evoskuil]

Thanks for the bug report @ggutoski and the fix @pmienk!