Various minor updates, v4 metadata changes. #973
Conversation
| </Filter> | ||
| <Filter Include="src\.libs"> | ||
| <UniqueIdentifier>{B726DF7D-6D1D-48FB-0000-000000000002}</UniqueIdentifier> | ||
| </Filter> |
There was a problem hiding this comment.
@pmienk Could you update the build system to prevent this?
There was a problem hiding this comment.
Will look at it now. Looks like you'd like to exclude anything 'hidden' - from both file and directory listings?
There was a problem hiding this comment.
There are a few hidden files that we use, but no hidden directories. Not sure if the hidden files are relevant to the source listings though.
There was a problem hiding this comment.
I had some errand .gitignore show up in one file listing, so I'm hoping we can ignore all of them or I can track it down and remove it. Its contents can move into the top-level one. But I'll rewrite the discovery function to allow for directory and file ignoring as separate parameters.
There was a problem hiding this comment.
Addressed by libbitcoin/libbitcoin-build#164. I did not see any use of hidden files and so have currently excluded them. Also finally pulled the file discovery code into utilities (it's also used in my in-progress cmake build)
Please do not merge until corresponding changes in other repos are ready.