Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config::block class. #992

Merged
merged 1 commit into from
Jul 17, 2018
Merged

add config::block class. #992

merged 1 commit into from
Jul 17, 2018

Conversation

toxeus
Copy link
Contributor

@toxeus toxeus commented Jul 16, 2018

The first intended use of this class is deserializing the genesis block.

@toxeus toxeus requested a review from evoskuil July 16, 2018 09:53
@coveralls
Copy link

coveralls commented Jul 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 81.574% when pulling 58b149d on toxeus:block into 2e1e679 on libbitcoin:master.

@toxeus
Copy link
Contributor Author

toxeus commented Jul 16, 2018

The AppVeyor build fails with

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.Cpp.Platform.targets(64,5): error MSB8020: The build tools for CTP_Nov2013 (Platform Toolset = 'CTP_Nov2013') cannot be found. To build using the CTP_Nov2013 build tools, please install CTP_Nov2013 build tools. Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Upgrade Solution...". [c:\git\libbitcoin\builds\msvc\vs2013\libbitcoin\libbitcoin.vcxproj]

Doesn't look like it's related to this patch.

evoskuil
evoskuil reviewed Jul 16, 2018
View reviewed changes
test/config/block.cpp Outdated
"00000000";


const static auto genesis_block = block(encoded_genesis_block, settings);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: static const

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

evoskuil
evoskuil approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@evoskuil evoskuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@toxeus
add config::block class.
58b149d 
The first intended use of this class is
deserializing the genesis block.
@evoskuil
Copy link
Member

@pmienk is looking into the appveyor thing, it’s not related to your changes.

@toxeus toxeus merged commit 4e2e0cc into libbitcoin:master Jul 17, 2018
@toxeus toxeus deleted the block branch July 17, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evoskuil evoskuil evoskuil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toxeus @coveralls @evoskuil