Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 unresolved external symbols? #498

Closed
xenos1337 opened this issue Jan 8, 2021 · 8 comments
Closed

4 unresolved external symbols? #498

xenos1337 opened this issue Jan 8, 2021 · 8 comments

Comments

@xenos1337
Copy link

xenos1337 commented Jan 8, 2021

No description provided.

@xenos1337 xenos1337 changed the title 4 unresolved externals? 4 unresolved external symbol? Jan 8, 2021
@xenos1337 xenos1337 changed the title 4 unresolved external symbol? 4 unresolved external symbols? Jan 8, 2021
@Emersont1
Copy link

What's in your Linker Settings?

@COM8
Copy link
Member

COM8 commented Jan 12, 2021

To me this one looks related to #478.

@xenos1337
Copy link
Author

xenos1337 commented Jan 12, 2021

.

@Emersont1
Copy link

You need to add cpr.lib to the "additional dependencies" section

@xenos1337
Copy link
Author

xenos1337 commented Jan 12, 2021

.

@Emersont1
Copy link

I'm not entirely sure, it depends on how you've downloaded the library. The Specifics of using visual studio isn't my strong point, but basically if you're compiling CPR from source (you downloaded a zip or similar of cpp files) you'll want to add a reference to the project you're building, if you downloaded a dll and some header files, you there should be a cpr.lib file in the /lib folder next to the include folder. If you're using VCPKG, visual studio should handle it for you (i think)

@Kid0h
Copy link

Kid0h commented Jan 22, 2021

where do I find cpr.lib? I'm really new to this sorry like in which folder

Have you managed to successfully build it as a static library?
If so, did you use vcpkg or just the source code..

@KingKili
Copy link
Member

KingKili commented Mar 5, 2021

where do I find cpr.lib? I'm really new to this sorry like in which folder

Have you managed to successfully build it as a static library?
If so, did you use vcpkg or just the source code..

I just created CI runs for static builds at least the unit tests seem to work with static linkage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants