erfam.h is installed

[sergiopasra]

With the current src/Makefile.am, erfam.h is installed alongside erfa.h when the users does make install

Is this correct or erfam.h is an internal header, used for compilation only?

[timj]

It should be installed. People rely on it for macros such as DPI and DAS2R.

[sergiopasra]

If the macros are public interface, I would expect the names to have a prefix, like ERFA_DPI. The prefix serves as a namespace to avoid colissions. We have very short names here: DC, DAU, etc.

For comparation, math.h macros are prefixed with M_

#define M_PI 3.14159265358979323846
#define M_PIl 3.141592653589793238462643383279502884L

gsl.h macros are prefixed with GSL (or _GSL if they are private macros)

[timj]

Indeed, but that is how SLALIB did it and that is how SOFA does it. It's got a long history. I'm not necessarily against an ERFA__ prefix though (if it doesn't complicate the importing script too much).

[sergiopasra]

Well, as the prefix macro thing is a different topic, I'm closing this, my original question has been answered.