Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guile Module, install .scm file that does load-extensions? #336

Closed
KoviRobi opened this issue Apr 7, 2020 · 4 comments
Closed

Guile Module, install .scm file that does load-extensions? #336

KoviRobi opened this issue Apr 7, 2020 · 4 comments

Comments

@KoviRobi
Copy link

KoviRobi commented Apr 7, 2020

Hi,

Description

I am installing libfive on Nix, and it doesn't seem to install the guile modules. I think it just does the basic cmake install steps (cmake flags: "-DCMAKE_BUILD_TYPE=Release"), any flags I need to give it to install the .scm/.go files?

Also, can I make a package for just libfive, then compile libfive-studio/libfive-guile using the existing libfive package (it will make the separate licenses easier to express).

Versions

@KoviRobi
Copy link
Author

Ah, sorry, I have found https://github.com/libfive/libfive/blob/master/doc/guide.md which does help, turns out I should have done

(load-extension "libfive-guile" "scm_init_libfive_modules")

@KoviRobi
Copy link
Author

Actually, perhaps there should be a libfive/modules.scm or something, e.g. https://www.gnu.org/software/guile/manual/html_node/Modules-and-Extensions.html#index-extensiondir-1 ?

@KoviRobi KoviRobi reopened this Apr 12, 2020
@KoviRobi KoviRobi changed the title Guile Module install (and install separately to base libfive) Guile Module, install .scm file that does load-extensions? Apr 12, 2020
@mkeeter
Copy link
Member

mkeeter commented Apr 13, 2020

Perhaps! The Guile module is pretty specialized for the Studio GUI right now, so less work has been put into making it friendly as a general-purpose module. If you want to open a PR that brings up to best practices, I'd be happy to merge.

@mkeeter
Copy link
Member

mkeeter commented Feb 20, 2021

Okay, this is done in #383 (along with a bunch of other changes).

@mkeeter mkeeter closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants