Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntArray object spam in JamepadControllerMonitor #24

Closed
IljaGnezdilov opened this issue Sep 1, 2022 · 6 comments · Fixed by #25
Closed

IntArray object spam in JamepadControllerMonitor #24

IljaGnezdilov opened this issue Sep 1, 2022 · 6 comments · Fixed by #25

Comments

@IljaGnezdilov
Copy link
Contributor

Method JamepadControllerMonitor#update() has line
IntArray disconnectedControllers = new IntArray(indexToController.size);

This IntArray is created every time (200-300 numbers per second). I want to suggest use some private IntArray variable for same reason.

@MrStahlfelge
Copy link
Member

Sure, go for it.

@IljaGnezdilov
Copy link
Contributor Author

Ok.

Can I branch from master and create pull request?

@MrStahlfelge
Copy link
Member

Yes, the usual workflow fork -> new branch -> commit -> push -> open PR

@IljaGnezdilov
Copy link
Contributor Author

I think that I must have some permissions.

Push failed
Remote: Permission to libgdx/gdx-controllers.git denied to IljaGnezdilov.
unable to access 'https://github.com/libgdx/gdx-controllers.git/': The requested URL returned error: 403

@MrStahlfelge
Copy link
Member

@IljaGnezdilov
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants