macOS on M1 #224
Merged
macOS on M1 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on: macOS Monterey Version 12.4 Chip Apple M1
|
I compiled this locally with |
|
@karlsabo Can you take a look at this? |
karlsabo
approved these changes
Apr 9, 2024
| @@ -82,7 +82,7 @@ tasks.withType(CppCompile::class).configureEach { | |||
|
|
|||
| dependencies { | |||
| implementation(project(":DrOpt")) | |||
| testImplementation("org.gradle.cpp-samples:googletest:1.9.0-gr4-SNAPSHOT") | |||
| //testImplementation("org.gradle.cpp-samples:googletest:1.9.0-gr4-SNAPSHOT") | |||
There was a problem hiding this comment.
Should we delete this line? Did Gradle drop support for googletest?
|
I do not remember why I included Google Test source code, instead of using it as a depenency. Today is 2024 and the commit is dated 2022, maybe there is a recent version and included source code is outdated. Also, there are some changes in build scripts for supporting M1 chip, maybe a recent version of Gradle do not need this changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on:
macOS Monterey
Version 12.4
Chip Apple M1
Observations:
It does not compile with "org.gradle.caching=true" in "gradle.properties"