Deploy to other protocols the reporting of progress transfer when pushing

[nulltoken]

#1412 added the basics of progress reporting during push for smart protocol.

The others protocols are a bit jealous and are giving a hard time to smart when no one is watching...

Also see libgit2/libgit2sharp#537 (comment)

[carlosmn]

What did you mean by "other protocols"? We only have the one protocol, so supporting progress would work for each transport. Has this been solved?

[nulltoken]

The problem mainly relates to local protocol IIRC. Besides push, it looks like Fetch is also lacking the progress reporting.

Following libgit2/libgit2sharp#862, changing test url in CloneFixture.CallsProgressCallbacks() to c:/testrepo or file:///c:/testrepo will fail as OnProgress isn't invoked.

/cc @dahlbyk

[carlosmn]

It looks like what's not being called is the textual progress output, which would be simply because we don't generate any text. I'm not sure that we can generate output that's similar to git's as we don't use the same walk algo.

[carlosmn]

Just sent a PR to handle the fetching part of the local transport, which should also send the packing progress to anything listening to it during push.

[carlosmn]

With these PRs merged, we now show or report the progress in each direction for local and smart protocol. Feel free to reopen if you notice discrepancies between the reporting and the expectations.

[nulltoken]

@dahlbyk IIRC we discussed about this while working on libgit2/libgit2sharp#862. Would you be willing to take a stab at covering it with some test coverage once libgit2/libgit2sharp#1049 is merged?

[dahlbyk]

You bet

[nulltoken]

@dahlbyk ❤️ Have you got already a failing test in mind? 😉

[dahlbyk]

Pretty sure our bug report came out of a test...figured I'd try to bring that back. 😁