Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "config::read::iterator_invalid_glob" fails with musl #3469

Closed
asandroq opened this issue Oct 15, 2015 · 3 comments
Closed

Test "config::read::iterator_invalid_glob" fails with musl #3469

asandroq opened this issue Oct 15, 2015 · 3 comments

Comments

@asandroq
Copy link

I have built libgit2 using musl as my C library. When running the included tests, one of them fails:

  1) Failure:
config::read::iterator_invalid_glob [/home/vagrant/libs/libgit2-0.23.2/tests/config/read.c:405]
  Expected function call to fail: git_config_iterator_glob_new(&iter, cfg, "*")

Machine:

vagrant@vagrant:~/libs/libgit2-build$ uname -a
Linux vagrant 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
vagrant@vagrant:~/libs/libgit2-build$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.10
DISTRIB_CODENAME=utopic
DISTRIB_DESCRIPTION="Ubuntu 14.10"
@carlosmn
Copy link
Member

We're passing the value down to regcomp(3) so it's musl who's returning something unexpected. It looks like it might not be taking REG_EXTENDED.

@carlosmn
Copy link
Member

One way to work around this would be to ask CMake to compile in the GNU regex implementation, like we do for Windows. It might get interesting since musl would also be exposing those functions.

@carlosmn
Copy link
Member

carlosmn commented Mar 9, 2016

You can add a rule to include GNU regex like we do on Windows if you want to use musl, but that feels like it's precisely what you don't want to do.

Closing as it's a bug in musl.

@carlosmn carlosmn closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants