tests: Bitbucket test with incorrect credentials in the URL fails sporadically

[mark-adams]

In 03c5877, acl_skip() was added to test_online_clone__bitbucket_uses_creds_in_url() because Bitbucket sporadically returns a 403 instead of the previously returned 401.

	/*
	 * TODO: as of March 2018, bitbucket sporadically fails with
	 * 403s instead of replying with a 401 - but only sometimes.
	 */
         cl_skip();

I'm a developer at Atlassian and am opening this issue (since I didn't see an existing one) so that we can better communicate about the issue and hopefully remove the cl_skip() soon.

@ethomson Can you confirm if this is still something that can be duplicated?

[ethomson]

Great question - I'd forgotten about this. I hit up Atlassian support, but I dropped the ball on getting this resolved.

I uncommented the cl_skip in this test and ran it again. (libgit2_clar -ionline -sonline::clone::bitbucket_falls_back) Now I'm getting consistent behavior, it's always returning 403s.

It would be interesting to know why this changed from 401 to 403... and it would be interesting to know why we were seeing different behavior - some responses were 401 and some were 403. Maybe we were seeing a behavior change going through a deployment? But that's really just a curiosity. :)