Tests fail when built against zlib-ng-compat #6728

sgallagher · 2024-02-06T18:45:27Z

Reproduction steps

On Fedora 40 (or any other system with zlib-ng-compat-devel available), build libgit2 with -DUSE_BUNDLED_ZLIB=OFF

Expected behavior

The test suite should succeed.

Actual behavior

  1) Failure:
pack::packbuilder::create_pack [/home/sgallagh/localworkspace/libgit2/tests/libgit2/pack/packbuilder.c:143]
  String mismatch: hex != "5d410bdf97cf896f9007681b92868471d636954b"
  '5f688cedc3a5132f15fc3352a35bc5dcb6a536a4' != '5d410bdf97cf896f9007681b92868471d636954b' (at byte 1)

  2) Failure:
pack::packbuilder::get_name [/home/sgallagh/localworkspace/libgit2/tests/libgit2/pack/packbuilder.c:151]
  String mismatch: "7f5fa362c664d68ba7221259be1cbd187434b2f0" != git_packbuilder_name(_packbuilder)
  '7f5fa362c664d68ba7221259be1cbd187434b2f0' != 'f120f6bbad709d0e3c021ca8f9d7c26c3882497b' (at byte 0)

  3) Failure:
pack::packbuilder::write_default_path [/home/sgallagh/localworkspace/libgit2/tests/libgit2/pack/packbuilder.c:159]
  Expression is not true: git_fs_path_exists("objects/pack/pack-7f5fa362c664d68ba7221259be1cbd187434b2f0.idx")

  4) Failure:
pack::packbuilder::permissions_standard [/home/sgallagh/localworkspace/libgit2/tests/libgit2/pack/packbuilder.c:184]
  Function call failed: (stat("pack-7f5fa362c664d68ba7221259be1cbd187434b2f0.idx", &statbuf))
  error -1 - no error

  5) Failure:
pack::packbuilder::permissions_readonly [/home/sgallagh/localworkspace/libgit2/tests/libgit2/pack/packbuilder.c:184]
  Function call failed: (stat("pack-7f5fa362c664d68ba7221259be1cbd187434b2f0.idx", &statbuf))
  error -1 - no error

  6) Failure:
pack::packbuilder::permissions_readwrite [/home/sgallagh/localworkspace/libgit2/tests/libgit2/pack/packbuilder.c:184]
  Function call failed: (stat("pack-7f5fa362c664d68ba7221259be1cbd187434b2f0.idx", &statbuf))
  error -1 - no error

Version of libgit2 (release number or SHA1)

libgit2 v1.7.1

Operating system(s) tested

Fedora 40, x86_64 and aarch64

Additional information

The zlib-ng project provides a compatible, drop-in replacement for the zlib API, however it does not guarantee identical bit-for-bit output. At present, it appears that the test suite for libgit2 is expecting that the packed data will match a known hash value that was created (I assume) using the bundled zlib implementation.

The text was updated successfully, but these errors were encountered:

ethomson · 2024-02-06T19:20:53Z

Interesting. What version of zlib-ng is this? There were a few recent releases that were simply buggy. I ask because I added zlib-ng as an optional built-in dependency in a fork and had no failures, but I agree, this may not be guaranteed to identical. But we have never seen this failure against other zlib implementations.

sgallagher · 2024-02-06T19:48:03Z

This was against zlib-ng 2.1.6 with only one patch (adding #define FAR to zconf.h.in).

See https://src.fedoraproject.org/rpms/zlib-ng/tree/rawhide

sgallagher · 2024-02-07T01:42:39Z

For the record, it's definitely zlib-ng. Swapping the library out with LD_PRELOAD=/path/to/libz.so.1 (provided by traditional zlib) makes the problem disappear entirely.

kloczek · 2024-02-10T15:21:37Z

For the record, it's definitely zlib-ng. Swapping the library out with LD_PRELOAD=/path/to/libz.so.1 (provided by traditional zlib) makes the problem disappear entirely.

What if someone don't have zlib? 😋
That is not a fixing the bug but swiping it under the carpet ..

sgallagher · 2024-02-10T15:39:28Z

That wasn't a recommendation, it was proof of the source of the issue.

kloczek · 2024-02-10T15:43:04Z

Looks like my ticket is duplicate of this one #6601 (I just closed it).
I'm using zlib-ng as well.

ethomson · 2024-03-09T12:13:45Z

Note - this is a dup of #5324 - and we should probably dig in and fix it.

ethomson · 2024-03-16T14:23:14Z

Thanks for the report! Should be fixed by #6762

kloczek · 2024-03-19T16:03:27Z

Just tested this PR with last release and test suite is ok now

+ cd libgit2-1.7.2
+ /usr/bin/ctest --test-dir x86_64-redhat-linux-gnu --output-on-failure --force-new-ctest-process -j48
Internal ctest changing into directory: /home/tkloczko/rpmbuild/BUILD/libgit2-1.7.2/x86_64-redhat-linux-gnu
Test project /home/tkloczko/rpmbuild/BUILD/libgit2-1.7.2/x86_64-redhat-linux-gnu
      Start  1: offline
      Start  2: invasive
      Start  3: online
      Start  4: online_customcert
      Start  5: gitdaemon
      Start  6: gitdaemon_namespace
      Start  7: gitdaemon_sha256
      Start  8: ssh
      Start  9: proxy
      Start 10: auth_clone
      Start 11: auth_clone_and_push
      Start 12: util
 1/12 Test  #7: gitdaemon_sha256 .................   Passed    0.02 sec
 2/12 Test  #6: gitdaemon_namespace ..............   Passed    0.02 sec
 3/12 Test  #2: invasive .........................   Passed    0.09 sec
 4/12 Test  #5: gitdaemon ........................   Passed    0.34 sec
 5/12 Test #11: auth_clone_and_push ..............   Passed    0.33 sec
 6/12 Test #12: util .............................   Passed    0.71 sec
 7/12 Test  #8: ssh ..............................   Passed    1.39 sec
 8/12 Test #10: auth_clone .......................   Passed    1.89 sec
 9/12 Test  #4: online_customcert ................   Passed    2.45 sec
10/12 Test  #9: proxy ............................   Passed    8.01 sec
11/12 Test  #3: online ...........................   Passed   37.11 sec
12/12 Test  #1: offline ..........................   Passed  157.18 sec

100% tests passed, 0 tests failed out of 12

Total Test time (real) = 157.18 sec

Thank you 👍

I've checked number of commits since last release and it now +270 commits.
Do you have any plans to release soon new version? 🤔 (just asking)

ethomson · 2024-03-19T16:10:15Z

VERY SOON. 😁

ethomson · 2024-03-19T16:10:45Z

I'm planning to merge this PR and ship v1.8 tonight. #6767

ethomson · 2024-03-19T16:12:22Z

@kloczek curious about your build — is it possible that #6734 is fixed in main as well?

kloczek · 2024-03-19T16:16:32Z

@kloczek curious about your build — is it possible that #6734 is fixed in main as well?

One sec 😋

kloczek · 2024-03-19T16:21:43Z

(sorry i took me a little to retrieve build log)
Nope ..

[tkloczko@pers-jacek .build_logs]$ xzcat libgit2.1.7.2-2.g2v.build_log.xz | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort | uniq -c | sort -nr
      1      62 -Wmaybe-uninitialized
      1       1 -Wuse-after-free
      1       1 -Wstringop-overread
      1       1 -Wdangling-pointer=
      1       1 -Warray-parameter=

Do you want me to test agaisnt master? 🤔

ethomson · 2024-03-19T16:31:12Z

If you are able, that would be grand. If not, I can take a look at it.

kloczek · 2024-03-19T17:33:03Z

OK ..one sec 😋

kloczek · 2024-03-19T17:57:01Z

stats

[tkloczko@pers-jacek SPECS]$ rpmbuild -ba libgit2.spec --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
     65 -Wmaybe-uninitialized
      1 -Wstringop-overread

extracted stderr

/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/strtol.c: In function ‘test_strtol__buffer_length_truncates’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/strtol.c:97:9: warning: ‘i32’ may be used uninitialized [-Wmaybe-uninitialized]
   97 |         cl_assert_equal_i(i32, 1);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/strtol.c:93:17: note: ‘i32’ was declared here
   93 |         int32_t i32;
      |                 ^
In function ‘reflog_parse’,
    inlined from ‘refdb_reflog_fs__read’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2158:15:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2036:20: warning: ‘c’ may be used uninitialized [-Wmaybe-uninitialized]
 2036 |                 if (c == '\t') {
      |                    ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c: In function ‘refdb_reflog_fs__read’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2017:22: note: ‘c’ was declared here
 2017 |                 char c;
      |                      ^
In function ‘reflog_parse’,
    inlined from ‘refdb_reflog_fs__read’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2158:15:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2036:20: warning: ‘c’ may be used uninitialized [-Wmaybe-uninitialized]
 2036 |                 if (c == '\t') {
      |                    ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c: In function ‘refdb_reflog_fs__read’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2017:22: note: ‘c’ was declared here
 2017 |                 char c;
      |                      ^
In function ‘git_regexp_match’,
    inlined from ‘git_config_backend_foreach_match’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:594:17:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/util/regexp.c:37:22: warning: ‘regex’ may be used uninitialized [-Wmaybe-uninitialized]
   37 |         if ((error = pcre_exec(*r, NULL, string, (int) strlen(string), 0, 0, NULL, 0)) < 0)
      |                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c: In function ‘git_config_backend_foreach_match’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:578:20: note: ‘regex’ was declared here
  578 |         git_regexp regex;
      |                    ^
In function ‘handle_next’,
    inlined from ‘test_dirent__diriter_with_fullname’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/dirent.c:270:3:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/dirent.c:253:9: warning: ‘filename’ may be used uninitialized [-Wmaybe-uninitialized]
  253 |         cl_assert_equal_s(fullpath+4, filename);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/dirent.c: In function ‘test_dirent__diriter_with_fullname’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/dirent.c:246:32: note: ‘filename’ was declared here
  246 |         const char *fullpath, *filename;
      |                                ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/strtol.c: In function ‘assert_l32_parses’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/strtol.c:7:9: warning: ‘i’ may be used uninitialized [-Wmaybe-uninitialized]
    7 |         cl_assert_equal_i(i, expected);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/util/strtol.c:5:17: note: ‘i’ was declared here
    5 |         int32_t i;
      |                 ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c: In function ‘git_config_get_multivar_foreach.constprop’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:1052:23: warning: ‘iter’ may be used uninitialized [-Wmaybe-uninitialized]
 1052 |         while ((err = iter->next(&entry, iter)) == 0) {
      |                       ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:1045:30: note: ‘iter’ was declared here
 1045 |         git_config_iterator *iter;
      |                              ^
In function ‘clar__assert’,
    inlined from ‘check_tree_entry’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:270:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/clar/clar.c:707:12: warning: ‘te’ may be used uninitialized [-Wmaybe-uninitialized]
  707 |         if (condition)
      |            ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c: In function ‘check_tree_entry’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:266:31: note: ‘te’ was declared here
  266 |         const git_tree_entry *te;
      |                               ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/config/snapshot.c: In function ‘test_config_snapshot__snapshot_from_in_memory’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/config/snapshot.c:163:9: warning: ‘backend’ may be used uninitialized [-Wmaybe-uninitialized]
  163 |         cl_git_pass(git_config_add_backend(cfg, backend, 0, NULL, 0));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/config/snapshot.c:151:29: note: ‘backend’ was declared here
  151 |         git_config_backend *backend;
      |                             ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c: In function ‘check_tree_range’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:371:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  371 |         cl_git_pass(git_iterator_for_tree(&i, head, &i_opts));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:360:19: note: ‘head’ was declared here
  360 |         git_tree *head;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/status/worktree.c: In function ‘test_status_worktree__at_head_parent’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/status/worktree.c:1351:23: warning: ‘parent_tree’ may be used uninitialized [-Wmaybe-uninitialized]
 1351 |         opts.baseline = parent_tree;
      |                       ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/status/worktree.c:1337:19: note: ‘parent_tree’ was declared here
 1337 |         git_tree *parent_tree;
      |                   ^
In function ‘git_iterator_for_workdir’,
    inlined from ‘test_iterator_workdir__bounded_submodules’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/workdir.c:1207:3:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/iterator.h:147:16: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  147 |         return git_iterator_for_workdir_ext(out, repo, NULL, index, tree, options);
      |                ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/workdir.c: In function ‘test_iterator_workdir__bounded_submodules’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/workdir.c:1187:19: note: ‘head’ was declared here
 1187 |         git_tree *head;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/apply/apply_helpers.c: In function ‘validate_workdir_unchanged’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/apply/apply_helpers.c:122:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  122 |         cl_git_pass(git_iterator_for_tree(&head_iterator, head, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/apply/apply_helpers.c:112:19: note: ‘head’ was declared here
  112 |         git_tree *head;
      |                   ^
In function ‘git_reference_iterator_new’,
    inlined from ‘test_refs_iterator__empty’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/refs/iterator.c:134:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refs.c:752:13: warning: ‘empty’ may be used uninitialized [-Wmaybe-uninitialized]
  752 |         if (git_repository_refdb__weakptr(&refdb, repo) < 0)
      |             ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/refs/iterator.c: In function ‘test_refs_iterator__empty’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/refs/iterator.c:129:25: note: ‘empty’ was declared here
  129 |         git_repository *empty;
      |                         ^
In function ‘git_grafts_get’,
    inlined from ‘test_grafts_shallow__shallow_oids’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c:55:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/grafts.c:241:21: warning: ‘grafts’ may be used uninitialized [-Wmaybe-uninitialized]
  241 |         if ((*out = git_oidmap_get(grafts->commits, oid)) == NULL)
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c: In function ‘test_grafts_shallow__shallow_oids’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c:49:21: note: ‘grafts’ was declared here
   49 |         git_grafts *grafts;
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/object/validate.c: In function ‘test_object_validate__cannot_parse_sha256_as_sha1’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/object/validate.c:75:9: warning: ‘valid’ may be used uninitialized [-Wmaybe-uninitialized]
   75 |         cl_assert_equal_i(0, valid);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/object/validate.c:72:13: note: ‘valid’ was declared here
   72 |         int valid;
      |             ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/object/validate.c: In function ‘test_object_validate__invalid_sha1’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/object/validate.c:86:9: warning: ‘valid’ may be used uninitialized [-Wmaybe-uninitialized]
   86 |         cl_assert_equal_i(0, valid);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/object/validate.c:83:13: note: ‘valid’ was declared here
   83 |         int valid;
      |             ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/submodules.c: In function ‘test_diff_submodules__dirty_submodule_2’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/submodules.c:157:17: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  157 |                 cl_git_pass(git_diff_tree_to_index(&diff2, g_repo, head, NULL, &opts));
      |                 ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/submodules.c:154:27: note: ‘head’ was declared here
  154 |                 git_tree *head;
      |                           ^
In function ‘git_grafts_get’,
    inlined from ‘test_grafts_shallow__cache_clearing’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c:69:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/grafts.c:241:21: warning: ‘grafts’ may be used uninitialized [-Wmaybe-uninitialized]
  241 |         if ((*out = git_oidmap_get(grafts->commits, oid)) == NULL)
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c: In function ‘test_grafts_shallow__cache_clearing’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c:61:21: note: ‘grafts’ was declared here
   61 |         git_grafts *grafts;
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c: In function ‘test_iterator_tree__icase_0’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:418:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  418 |         cl_git_pass(git_iterator_for_tree(&i, head, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:411:19: note: ‘head’ was declared here
  411 |         git_tree *head;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c: In function ‘test_grafts_shallow__errors_on_borked’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c:94:9: warning: ‘grafts’ may be used uninitialized [-Wmaybe-uninitialized]
   94 |         cl_git_fail(git_grafts_refresh(grafts));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/grafts/shallow.c:88:21: note: ‘grafts’ was declared here
   88 |         git_grafts *grafts;
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c: In function ‘test_worktree_worktree__init’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c:216:9: warning: ‘branch’ may be used uninitialized [-Wmaybe-uninitialized]
  216 |         git_reference_free(branch);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c:203:24: note: ‘branch’ declared here
  203 |         git_reference *branch;
      |                        ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/submodules.c: In function ‘test_diff_submodules__submod2_head_to_index’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/submodules.c:222:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  222 |         cl_git_pass(git_diff_tree_to_index(&diff, g_repo, head, NULL, &opts));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/submodules.c:207:19: note: ‘head’ was declared here
  207 |         git_tree *head;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c: In function ‘test_iterator_tree__icase_1’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:454:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  454 |         cl_git_pass(git_iterator_for_tree(&i, head, &i_opts));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:442:19: note: ‘head’ was declared here
  442 |         git_tree *head;
      |                   ^
In function ‘merge_preference’,
    inlined from ‘git_merge_analysis_for_ref’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/merge.c:3272:15,
    inlined from ‘analysis_from_branch’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/merge/analysis.c:74:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/merge.c:3243:9: warning: ‘config’ may be used uninitialized [-Wmaybe-uninitialized]
 3243 |         git_config_free(config);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/merge.c: In function ‘analysis_from_branch’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/merge.c:3216:21: note: ‘config’ declared here
 3216 |         git_config *config;
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c: In function ‘test_worktree_worktree__add_remove_add’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c:237:9: warning: ‘branch’ may be used uninitialized [-Wmaybe-uninitialized]
  237 |         git_reference_free(branch);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c:225:24: note: ‘branch’ declared here
  225 |         git_reference *branch;
      |                        ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c: In function ‘test_iterator_tree__icase_2’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:596:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  596 |         cl_git_pass(git_iterator_for_tree(&i, head, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/tree.c:545:19: note: ‘head’ was declared here
  545 |         git_tree *head;
      |                   ^
In function ‘git_object_id’,
    inlined from ‘git_commit_id’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:38:9,
    inlined from ‘test_graph_ahead_behind__returns_correct_result’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/graph/ahead_behind.c:43:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:298:9: warning: ‘other’ may be used uninitialized [-Wmaybe-uninitialized]
  298 |         GIT_ASSERT_ARG_WITH_RETVAL(obj, NULL);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/graph/ahead_behind.c: In function ‘test_graph_ahead_behind__returns_correct_result’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/graph/ahead_behind.c:30:21: note: ‘other’ was declared here
   30 |         git_commit *other;
      |                     ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/tests.c: In function ‘test_index_tests__can_iterate’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/tests.c:1114:17: warning: ‘entry’ may be used uninitialized [-Wmaybe-uninitialized]
 1114 |                 cl_assert_equal_i(entry->file_size, test_entries[i].file_size);
      |                 ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/tests.c:1092:32: note: ‘entry’ was declared here
 1092 |         const git_index_entry *entry;
      |                                ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c: In function ‘test_worktree_worktree__add_locked’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c:285:9: warning: ‘branch’ may be used uninitialized [-Wmaybe-uninitialized]
  285 |         git_reference_free(branch);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/worktree/worktree.c:268:24: note: ‘branch’ declared here
  268 |         git_reference *branch;
      |                        ^
In function ‘git_odb_add_backend’,
    inlined from ‘test_odb_backend_mempack__initialize’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/mempack.c:18:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/odb.c:618:16: warning: ‘backend’ may be used uninitialized [-Wmaybe-uninitialized]
  618 |         return add_backend_internal(odb, backend, priority, false, 0);
      |                ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/mempack.c: In function ‘test_odb_backend_mempack__initialize’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/mempack.c:14:26: note: ‘backend’ was declared here
   14 |         git_odb_backend *backend;
      |                          ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/conflicts.c: In function ‘test_index_conflicts__iterate’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/conflicts.c:224:9: warning: ‘iterator’ may be used uninitialized [-Wmaybe-uninitialized]
  224 |         cl_git_pass(git_index_conflict_next(&conflict_entry[0], &conflict_entry[1], &conflict_entry[2], iterator));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/conflicts.c:218:38: note: ‘iterator’ was declared here
  218 |         git_index_conflict_iterator *iterator;
      |                                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c: In function ‘test_win32_forbidden__can_diff_tree_to_index’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c:98:9: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
   98 |         cl_git_pass(git_diff_tree_to_index(&diff, repo, tree, NULL, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c:95:19: note: ‘tree’ was declared here
   95 |         git_tree *tree;
      |                   ^
In function ‘git_object_free’,
    inlined from ‘git_commit_free’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:33:2,
    inlined from ‘test_win32_forbidden__can_diff_index_to_workdir’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c:134:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:290:12: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
  290 |         if (object == NULL)
      |            ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c: In function ‘test_win32_forbidden__can_diff_index_to_workdir’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c:121:19: note: ‘tree’ was declared here
  121 |         git_tree *tree;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/multiple.c: In function ‘test_odb_backend_multiple__initialize’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/multiple.c:33:22: warning: ‘backend’ may be used uninitialized [-Wmaybe-uninitialized]
   33 |         _fake_filled = (fake_backend *)backend;
      |                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/multiple.c:25:26: note: ‘backend’ was declared here
   25 |         git_odb_backend *backend;
      |                          ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c: In function ‘assert_trailers’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c:5:35: warning: ‘arr.trailers’ may be used uninitialized [-Wmaybe-uninitialized]
    5 |         git_message_trailer_array arr;
      |                                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c:15:9: warning: ‘arr.count’ may be used uninitialized [-Wmaybe-uninitialized]
   15 |         cl_assert_equal_sz(arr.count, count);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c:5:35: note: ‘arr.count’ was declared here
    5 |         git_message_trailer_array arr;
      |                                   ^
In function ‘git__free’,
    inlined from ‘git_message_trailer_array_free’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/trailer.c:428:2,
    inlined from ‘assert_trailers’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c:22:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/util/alloc.h:39:9: warning: ‘arr._trailer_block’ may be used uninitialized [-Wmaybe-uninitialized]
   39 |         git__allocator.gfree(ptr);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c: In function ‘assert_trailers’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/message/trailer.c:5:35: note: ‘arr._trailer_block’ was declared here
    5 |         git_message_trailer_array arr;
      |                                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c: In function ‘test_win32_forbidden__can_diff_tree_to_tree’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c:110:9: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
  110 |         cl_git_pass(git_diff_tree_to_tree(&diff, repo, tree, tree, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/win32/forbidden.c:107:19: note: ‘tree’ was declared here
  107 |         git_tree *tree;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/escape.c: In function ‘test_submodule_escape__from_gitdir’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/escape.c:62:9: warning: ‘sm_location’ may be used uninitialized [-Wmaybe-uninitialized]
   62 |         cl_assert_equal_i(GIT_SUBMODULE_STATUS_IN_INDEX | GIT_SUBMODULE_STATUS_IN_HEAD, sm_location);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/escape.c:37:22: note: ‘sm_location’ declared here
   37 |         unsigned int sm_location;
      |                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/escape.c: In function ‘test_submodule_escape__from_gitdir_windows’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/escape.c:96:9: warning: ‘sm_location’ may be used uninitialized [-Wmaybe-uninitialized]
   96 |         cl_assert_equal_i(GIT_SUBMODULE_STATUS_IN_INDEX | GIT_SUBMODULE_STATUS_IN_HEAD, sm_location);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/escape.c:71:22: note: ‘sm_location’ declared here
   71 |         unsigned int sm_location;
      |                      ^
In function ‘git_odb_add_backend’,
    inlined from ‘setup_backend’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/simple.c:19:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/odb.c:618:16: warning: ‘backend’ may be used uninitialized [-Wmaybe-uninitialized]
  618 |         return add_backend_internal(odb, backend, priority, false, 0);
      |                ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/simple.c: In function ‘setup_backend’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/simple.c:14:26: note: ‘backend’ was declared here
   14 |         git_odb_backend *backend;
      |                          ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/tree.c: In function ‘test_diff_tree__larger_hunks’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/tree.c:283:39: warning: ‘num_l’ may be used uninitialized [-Wmaybe-uninitialized]
  283 |                         for (l = 0; l < num_l; ++l) {
      |                                       ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/tree.c:259:39: note: ‘num_l’ was declared here
  259 |         size_t d, num_d, h, num_h, l, num_l;
      |                                       ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/index.c: In function ‘test_iterator_index__range_icase’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/index.c:258:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  258 |         cl_git_pass(git_index_read_tree(index, head));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/iterator/index.c:251:19: note: ‘head’ was declared here
  251 |         git_tree *head;
      |                   ^
In function ‘git_config_next’,
    inlined from ‘test_config_read__iterator’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/config/read.c:366:16:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:1171:16: warning: ‘iter’ may be used uninitialized [-Wmaybe-uninitialized]
 1171 |         return iter->next(entry, iter);
      |                ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/config/read.c: In function ‘test_config_read__iterator’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/config/read.c:353:30: note: ‘iter’ was declared here
  353 |         git_config_iterator *iter;
      |                              ^
In function ‘git_regexp_match’,
    inlined from ‘git_config_backend_foreach_match’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:594:17:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/util/regexp.c:37:22: warning: ‘regex’ may be used uninitialized [-Wmaybe-uninitialized]
   37 |         if ((error = pcre_exec(*r, NULL, string, (int) strlen(string), 0, 0, NULL, 0)) < 0)
      |                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c: In function ‘git_config_backend_foreach_match’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/config.c:578:20: note: ‘regex’ was declared here
  578 |         git_regexp regex;
      |                    ^
In function ‘git_atomic__swap’,
    inlined from ‘set_refdb’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/repository.c:115:15,
    inlined from ‘git_repository_set_refdb’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/repository.c:1648:2,
    inlined from ‘test_odb_backend_nobackend__initialize’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/nobackend.c:25:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/util/thread.h:184:9: warning: ‘refdb’ may be used uninitialized [-Wmaybe-uninitialized]
  184 |         __atomic_exchange(ptr, &newval, &foundval, __ATOMIC_SEQ_CST);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/nobackend.c: In function ‘test_odb_backend_nobackend__initialize’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/odb/backend/nobackend.c:12:20: note: ‘refdb’ was declared here
   12 |         git_refdb *refdb;
      |                    ^
In function ‘git_submodule_owner’,
    inlined from ‘test_submodule_lookup__can_be_dupped’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/lookup.c:71:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/submodule.c:1063:25: warning: ‘sm_duplicate’ may be used uninitialized [-Wmaybe-uninitialized]
 1063 |         return submodule->repo;
      |                         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/lookup.c: In function ‘test_submodule_lookup__can_be_dupped’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/submodule/lookup.c:49:24: note: ‘sm_duplicate’ was declared here
   49 |         git_submodule *sm_duplicate;
      |                        ^
In function ‘git_object_id’,
    inlined from ‘git_commit_id’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:38:9,
    inlined from ‘test_graph_descendant_of__returns_correct_result’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/graph/descendant_of.c:34:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:298:9: warning: ‘other’ may be used uninitialized [-Wmaybe-uninitialized]
  298 |         GIT_ASSERT_ARG_WITH_RETVAL(obj, NULL);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/graph/descendant_of.c: In function ‘test_graph_descendant_of__returns_correct_result’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/graph/descendant_of.c:27:21: note: ‘other’ was declared here
   27 |         git_commit *other;
      |                     ^
In function ‘git_object_free’,
    inlined from ‘git_commit_free’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:33:2,
    inlined from ‘test_checkout_index__initialize’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/checkout/index.c:23:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:290:12: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
  290 |         if (object == NULL)
      |            ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/checkout/index.c: In function ‘test_checkout_index__initialize’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/checkout/index.c:16:19: note: ‘tree’ was declared here
   16 |         git_tree *tree;
      |                   ^
In function ‘git_object_id’,
    inlined from ‘git_commit_id’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:38:9,
    inlined from ‘test_commit_create__from_stage_nochanges’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:72:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:298:9: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
  298 |         GIT_ASSERT_ARG_WITH_RETVAL(obj, NULL);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c: In function ‘test_commit_create__from_stage_nochanges’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:58:19: note: ‘tree’ was declared here
   58 |         git_tree *tree;
      |                   ^
In function ‘git_object_id’,
    inlined from ‘git_commit_id’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:38:9,
    inlined from ‘test_commit_create__from_stage_simple’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:48:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:298:9: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
  298 |         GIT_ASSERT_ARG_WITH_RETVAL(obj, NULL);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c: In function ‘test_commit_create__from_stage_simple’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:28:19: note: ‘tree’ was declared here
   28 |         git_tree *tree;
      |                   ^
In function ‘memcpy’,
    inlined from ‘git_oid_raw_cpy’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/oid.h:202:2,
    inlined from ‘git_oid_cpy’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/oid.c:267:9,
    inlined from ‘dup_reflog’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/transaction.c:270:3,
    inlined from ‘git_transaction_set_reflog’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/transaction.c:296:15,
    inlined from ‘git_stash_drop’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/stash.c:1252:15:
/usr/include/bits/string_fortified.h:29:10: warning: ‘__builtin_memcpy’ reading 20 bytes from a region of size 0 [-Wstringop-overread]
   29 |   return __builtin___memcpy_chk (__dest, __src, __len,
      |          ^
In function ‘git_stash_drop’:
lto1: note: source object is likely at address zero
In function ‘git_object_id’,
    inlined from ‘git_commit_id’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:38:9,
    inlined from ‘test_commit_create__from_stage_newrepo’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:104:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:298:9: warning: ‘commit’ may be used uninitialized [-Wmaybe-uninitialized]
  298 |         GIT_ASSERT_ARG_WITH_RETVAL(obj, NULL);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c: In function ‘test_commit_create__from_stage_newrepo’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:82:21: note: ‘commit’ was declared here
   82 |         git_commit *commit;
      |                     ^
In function ‘git_object_free’,
    inlined from ‘git_commit_free’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object_api.c:33:2,
    inlined from ‘test_commit_create__from_stage_newrepo’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:107:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/object.c:290:12: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
  290 |         if (object == NULL)
      |            ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c: In function ‘test_commit_create__from_stage_newrepo’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/commit/create.c:83:19: note: ‘tree’ was declared here
   83 |         git_tree *tree;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/index.c: In function ‘test_diff_index__to_index’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/index.c:291:9: warning: ‘diff’ may be used uninitialized [-Wmaybe-uninitialized]
  291 |         cl_git_pass(git_diff_foreach(
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/index.c:279:19: note: ‘diff’ was declared here
  279 |         git_diff *diff;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/apply/apply_helpers.c: In function ‘validate_index_unchanged’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/apply/apply_helpers.c:95:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
   95 |         cl_git_pass(git_iterator_for_tree(&head_iterator, head, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/apply/apply_helpers.c:88:19: note: ‘head’ was declared here
   88 |         git_tree *head;
      |                   ^
In function ‘reflog_parse’,
    inlined from ‘refdb_reflog_fs__read’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2158:15:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2036:20: warning: ‘c’ may be used uninitialized [-Wmaybe-uninitialized]
 2036 |                 if (c == '\t') {
      |                    ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c: In function ‘refdb_reflog_fs__read’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/refdb_fs.c:2017:22: note: ‘c’ was declared here
 2017 |                 char c;
      |                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c: In function ‘test_index_read_index__initialize’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c:19:9: warning: ‘head_ref’ may be used uninitialized [-Wmaybe-uninitialized]
   19 |         git_reference_free(head_ref);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c:12:24: note: ‘head_ref’ was declared here
   12 |         git_reference *head_ref;
      |                        ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c:16:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
   16 |         cl_git_pass(git_reset(_repo, head, GIT_RESET_HARD, NULL));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c:11:21: note: ‘head’ was declared here
   11 |         git_object *head;
      |                     ^
In function ‘git_describe_format’,
    inlined from ‘assert_describe_workdir’ at /home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/describe/describe_helpers.c:38:2:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/src/libgit2/describe.c:862:9: warning: ‘result’ may be used uninitialized [-Wmaybe-uninitialized]
  862 |         GIT_BUF_WRAP_PRIVATE(out, git_describe__format, result, given);
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/describe/describe_helpers.c: In function ‘assert_describe_workdir’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/describe/describe_helpers.c:35:30: note: ‘result’ was declared here
   35 |         git_describe_result *result;
      |                              ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c: In function ‘test_index_read_index__handles_conflicts’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c:199:9: warning: ‘conflict_iterator’ may be used uninitialized [-Wmaybe-uninitialized]
  199 |         cl_git_pass(git_index_conflict_next(
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/index/read_index.c:172:38: note: ‘conflict_iterator’ was declared here
  172 |         git_index_conflict_iterator *conflict_iterator;
      |                                      ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/workdir.c: In function ‘test_diff_workdir__larger_hunks’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/workdir.c:1066:47: warning: ‘num_l’ may be used uninitialized [-Wmaybe-uninitialized]
 1066 |                                 for (l = 0; l < num_l; ++l) {
      |                                               ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/workdir.c:1026:42: note: ‘num_l’ was declared here
 1026 |         size_t i, d, num_d, h, num_h, l, num_l;
      |                                          ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/workdir.c: In function ‘test_diff_workdir__cannot_diff_against_a_bare_repository’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/workdir.c:1186:9: warning: ‘tree’ may be used uninitialized [-Wmaybe-uninitialized]
 1186 |         cl_assert_equal_i(
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/workdir.c:1177:19: note: ‘tree’ was declared here
 1177 |         git_tree *tree;
      |                   ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/rebase/inmemory.c: In function ‘test_rebase_inmemory__can_resolve_conflicts’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/rebase/inmemory.c:91:9: warning: ‘rebase_index’ may be used uninitialized [-Wmaybe-uninitialized]
   91 |         cl_assert(git_index_has_conflicts(rebase_index));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/rebase/inmemory.c:61:20: note: ‘rebase_index’ was declared here
   61 |         git_index *rebase_index, *repo_index;
      |                    ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/patch.c: In function ‘test_diff_patch__hunks_have_correct_line_numbers’:
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/patch.c:288:9: warning: ‘head’ may be used uninitialized [-Wmaybe-uninitialized]
  288 |         cl_git_pass(git_diff_tree_to_workdir(&diff, g_repo, head, &opt));
      |         ^
/home/tkloczko/rpmbuild/BUILD/libgit2-115db540cfb633c2a618aa60757454839047eadf/tests/libgit2/diff/patch.c:262:19: note: ‘head’ was declared here
  262 |         git_tree *head;
      |                   ^

ethomson · 2024-03-19T19:00:26Z

Better! Thanks for the details, that's a big help.

kloczek · 2024-03-19T19:08:27Z

Give me shout if you will need such test 😋

ethomson · 2024-03-19T19:48:52Z

Will do - I don't know why these warnings don't emit anything for my gcc (gcc (Ubuntu 13.2.0-9ubuntu1) 13.2.0). 😢

kloczek · 2024-03-20T10:40:01Z

[-Wmaybe-uninitialized] are emitted only when LTO is used.

kloczek mentioned this issue Feb 10, 2024

1.7.0: test suite is failing in two units #6601

Closed

ethomson mentioned this issue Mar 16, 2024

packbuilder: adjust nondeterministic tests #6762

Merged

ethomson closed this as completed Mar 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests fail when built against zlib-ng-compat #6728

Tests fail when built against zlib-ng-compat #6728

sgallagher commented Feb 6, 2024

ethomson commented Feb 6, 2024

sgallagher commented Feb 6, 2024

sgallagher commented Feb 7, 2024

kloczek commented Feb 10, 2024

sgallagher commented Feb 10, 2024

kloczek commented Feb 10, 2024

ethomson commented Mar 9, 2024

ethomson commented Mar 16, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

ethomson commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 19, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 19, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 20, 2024

Tests fail when built against zlib-ng-compat #6728

Tests fail when built against zlib-ng-compat #6728

Comments

sgallagher commented Feb 6, 2024

Reproduction steps

Expected behavior

Actual behavior

Version of libgit2 (release number or SHA1)

Operating system(s) tested

Additional information

ethomson commented Feb 6, 2024

sgallagher commented Feb 6, 2024

sgallagher commented Feb 7, 2024

kloczek commented Feb 10, 2024

sgallagher commented Feb 10, 2024

kloczek commented Feb 10, 2024

ethomson commented Mar 9, 2024

ethomson commented Mar 16, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

ethomson commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 19, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 19, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 19, 2024

ethomson commented Mar 19, 2024

kloczek commented Mar 20, 2024