Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository crashes on bytes paths on Python 3 #588

Closed
thomwiggers opened this issue Jan 2, 2016 · 1 comment · Fixed by #593
Closed

Repository crashes on bytes paths on Python 3 #588

thomwiggers opened this issue Jan 2, 2016 · 1 comment · Fixed by #593

Comments

@thomwiggers
Copy link
Contributor

If the path supplied to Repository is a bytes objects as in Python 3, pygit2 crashes. This is inconvenient, as all filesystem utilities will return bytes objects they will actually return strs. The os libraries will accept bytes though.

Eg. as used in powerline raises must be str, not bytes
@thomwiggers thomwiggers mentioned this issue Feb 16, 2016
Merged
@thomwiggers
Copy link
Contributor Author

As I posted on #593:

I'm actually not sure if this is pygit2's problem or the problem of the applications using pygit2's API. I have the feeling that lots of other parts of pygit2 will also fail if they are passed paths as bytes-strings. However, if you reach this decision, it should probably be documented clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix repository crash if path passed is not a str
1 participant
@thomwiggers