Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added igl namespace average_onto_faces.cpp #1441

Merged
merged 1 commit into from Apr 11, 2020
Merged

Added igl namespace average_onto_faces.cpp #1441

merged 1 commit into from Apr 11, 2020

Conversation

BruegelN
Copy link
Contributor

@BruegelN BruegelN commented Mar 10, 2020 •
edited

Added igl:: to average_onto_faces.cpp
Might solve libigl/libigl-python-bindings#35

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@BruegelN BruegelN force-pushed the fix-average_onto_faces-namespace branch from e0bc8b6 to 5c7298c Compare April 8, 2020 22:30
@teseoch teseoch changed the base branch from dev to master April 11, 2020 16:25
@teseoch teseoch self-requested a review April 11, 2020 16:26
@jdumas jdumas merged commit b550323 into libigl:master Apr 11, 2020
@BruegelN BruegelN deleted the fix-average_onto_faces-namespace branch October 1, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumas jdumas jdumas approved these changes

@teseoch teseoch teseoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BruegelN @jdumas @teseoch