New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Catch2 to latest version (v2.13.8) #1972

Merged

alecjacobson merged 1 commit into libigl:main from BruegelN:update-catch2-for-recent-glibc

Feb 18, 2022

Contributor

BruegelN commented Feb 12, 2022 •

edited

The previously used Catch2 version fails to build with glibc >= 2.34.
As MINSIGSTKSZ can no longer be assumed to be constant:

It's fixed in Catch2 since 2.13.5: https://github.com/catchorg/Catch2/releases/tag/v2.13.5

The upcoming Ubuntu LTS (22.04) will ship with an incompatible glibc version.

Checklist

All changes meet libigl style-guidelines.
Adds new .cpp file.
Adds corresponding unit test.
This is a minor change.


          Update Catch2 to latest version (v2.13.8)

2b3ab32

The previously used Catch2 version fails to build with glibc>= 2.34.
As MINSIGSTKSZ can no longer be assumed to be constant:
* https://sourceware.org/git/?p=glibc.git;a=commit;h=6c57d320484988e87e446e2e60ce42816bf51d53
* https://sourceware.org/pipermail/libc-alpha/2021-August/129718.html

It's fixed in Catch2 since 2.13.5: https://github.com/catchorg/Catch2/releases/tag/v2.13.5

The upcoming Ubuntu LTS (22.04) will ship with an incompatible glibc version.

alecjacobson merged commit 799b54c into libigl:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment