Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewerData needs EIGEN_MAKE_ALIGNED_OPERATOR_NEW #743

Closed
evouga opened this issue Apr 6, 2018 · 6 comments
Closed

ViewerData needs EIGEN_MAKE_ALIGNED_OPERATOR_NEW #743

evouga opened this issue Apr 6, 2018 · 6 comments
Labels

Comments

@evouga
Copy link
Contributor

evouga commented Apr 6, 2018

I am getting crashes because
Eigen::Vector4f line_color;
in ViewerData is not correctly aligned.

@evouga evouga changed the title ViewData needs EIGEN_MAKE_ALIGNED_OPERATOR_NEW ViewerData needs EIGEN_MAKE_ALIGNED_OPERATOR_NEW Apr 6, 2018
@danielepanozzo
Copy link
Contributor

Which OS? If it is windows, can you confirm that you are compiling in 64-bit mode?

@evouga
Copy link
Contributor Author

evouga commented Apr 6, 2018

Windows 32-bit.

Is this unsupported? I didn't see anything about 32-bit in the tutorial.

@jdumas
Copy link
Collaborator

jdumas commented Apr 6, 2018

Yes there is this note in the tutorial:

Note for windows users: libigl only supports the Microsoft Visual Studio 2015 compiler in 64bit mode. It will not work with a 32bit build and it will not work with older versions of visual studio.

That being said, it probably wouldn't hurt to add this macro. We could also add an error message in the CMake (this is easy to detect), and ask the user to compile in 64bit mode.

@evouga
Copy link
Contributor Author

evouga commented Apr 6, 2018

Hmm I don't see that text either at https://github.com/libigl/libigl/blob/master/README.md or at http://libigl.github.io/libigl/.

In any case it's easy enough for me to switch to 64-bit mode, but some error in CMake would certainly be useful.

@jdumas
Copy link
Collaborator

jdumas commented Apr 6, 2018

The note is hidden in the tutorial webpage (but we should make it more visible):
https://libigl.github.io/libigl/tutorial/tutorial.html

@jdumas jdumas added the viewer label Apr 8, 2018
@alecjacobson
Copy link
Contributor

I guess this was fixed by #1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants