ideviceinstaller rejects valid ipa when there is no individual zip entry for the app directory

[greg-dennis]

ipa files are in zip file format, and zip files are not required to list directories as individual entries. Because of the following four lines of code, ideviceinstaller rejects the ipa as invalid if the .app directory isn't listed individually:
https://github.com/libimobiledevice/ideviceinstaller/blob/master/src/ideviceinstaller.c#L245

Removing those four lines of code fixes the issue. Is there a case of an invalid ipa that those lines are catching?

Some zip implementations do not add directory entries by default, and some unzip implementations don't behave correctly if they are present. Those zip implementations that do list directories by default usually provide an option to do so (with the standard zip command line tool, the -D option will do this).

Thanks for all your work on this great tool!

[shanechin]

I experienced this issue while trying to play around with trigger.io:

http://stackoverflow.com/questions/25614629/why-does-forge-trigger-io-run-ios-not-install-my-application/25637688#25637688

[FunkyM]

Could you still please describe on what platform and with which tool you are creating the IPA file that causes this problem? Would like to reproduce and verify for the future.
I don't remember the exact scenario anymore but the current code logic was run against hundred thousands of IPA archives already and this wasn't evident yet.
Anyways, I've removed the four lines in git master as they should not really matter and fix your use-case.
If something fails we'll probably know soon. Thanks for reporting.