Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion between bin and xml format is dependent on timezone #14

Closed
hyperair opened this issue Mar 27, 2014 · 5 comments
Closed

conversion between bin and xml format is dependent on timezone #14

hyperair opened this issue Mar 27, 2014 · 5 comments
Labels

Comments

@hyperair
Copy link
Contributor

$ TZ=Asia/Singapore plistutil -i test/data/2.plist -o 2.plist.bin
$ TZ=UTC plistutil -i 2.plist.bin -o 2.plist.utc.xml
$ TZ=Asia/Singapore plistutil -i 2.plist.bin -o 2.plist.sgt.xml

$ diff -u 2.plist.utc.xml 2.plist.sgt.xml
....
-       <date>2009-02-12T14:23:00Z</date>
+       <date>2009-02-12T22:23:00Z</date>
....
@FunkyM
Copy link
Member

FunkyM commented Mar 29, 2014

Note for us: After fixing the bug, we should not forget to add this as a test case.

@nikias
Copy link
Member

nikias commented Apr 1, 2014

Fixed and added test cases. @hyperair testing appreciated :)

@nikias nikias closed this as completed Apr 1, 2014
@hyperair
Copy link
Contributor Author

hyperair commented Apr 2, 2014

Hmm, looking at the test cases, I see that it does multiple plist_cmp's but doesn't necessarily fail if one of the earlier plist_cmp's exits with a failure code. Perhaps a "set -e" is needed?

@hyperair
Copy link
Contributor Author

hyperair commented Apr 2, 2014

Apart from that, this looks good.

@nikias
Copy link
Member

nikias commented Apr 2, 2014

@hyperair indeed set -e is required. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants