Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test builds with -Werror #2670

Open
novomesk opened this issue Jul 17, 2023 · 1 comment
Open

Test builds with -Werror #2670

novomesk opened this issue Jul 17, 2023 · 1 comment
Labels
bug Something isn't working building/portability Platform-specific issues, build issues unrelated to 1.0 Things that need not be done before the 1.0 version milestone

Comments

@novomesk
Copy link
Contributor

Hello,

there is an report from gentoo: https://bugs.gentoo.org/910099 (media-libs/libjxl-0.8.2-r1 adds -Werror flag on its own)

There is a following line in https://github.com/libjxl/libjxl/blob/0e265bfb2f5554d476c7014e43fb927a174b576e/tools/CMakeLists.txt#L386C1-L386C66
target_compile_options(libjxl_test PRIVATE -Wall -Wextra -Werror)

Would it be possible to make the -Werror optional?
@yota-code
Copy link

could be linked to #2669

@mo271 mo271 added bug Something isn't working building/portability Platform-specific issues, build issues unrelated to 1.0 Things that need not be done before the 1.0 version milestone labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working building/portability Platform-specific issues, build issues unrelated to 1.0 Things that need not be done before the 1.0 version milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mo271 @yota-code @novomesk