default timeout when sending only one frame

[spale75]

Expected Behavior

nemesis should quit after the last frame has been sent and not wait for -i or the default of 1 second.

Actual Behavior

nemesis waits for -i after the last frame has been sent.

Steps to Reproduce the Problem

send a frame ;)

Specifications

• Version: 1.6
• Platform: Ubuntu bionic

Solution

For me, it seem line 344 of nemesis-functions.c isn't working as it should.

344                 if (count != 0 && interval >= 0)
345                         usleep(interval);

If count would be 0, it should not sleep. So I think there's an issue with the counter (off by one?)

[troglobit]

Ah, good catch! Haven't looked at it in detail, but maybe count isn't decremented as it should?

[spale75]

I think I've got it.

in the do { } while() loop of the nemesis_send_frame() function, count can never be 0. The while condition prevents that. That means the usleep() has to be skipped on the last packet which is count==1, not count==0.

changing 344 to: if (count != 1 && interval >= 0)

that should solve it.

[troglobit]

There, should work better now. Thanks for reporting this :-)