Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect integration test #118

Open
igor-egorov opened this issue Mar 16, 2021 · 0 comments
Open

Multiselect integration test #118

igor-egorov opened this issue Mar 16, 2021 · 0 comments

Comments

@igor-egorov
Copy link
Member

Testing of #111 uncovers that protocol negotiation happens more often than in the master branch. Moreover, that negotiation often fails due to unexpected messages which may indicate the error-prone messages flow and order.

The issue is to create some integration test for the multiselect protocol to reveal such errors and verify messages order correctness without any dependency on underlying implementation (either callbacks or tasks scheduling - #111 addresses it).

Log example of multiselect issues when #111 gets employed:

[2021-03-15 15:29:45.873680000][th:584649][info] multiselect got a unexpected request-response combination - sending 'ls'
[2021-03-15 15:29:45.873701000][th:584649][warning] listener_mgr can not negotiate protocols, other side has violated a protocol and sent an unexpected message
[2021-03-15 15:29:45.984183000][th:584649][info] multiselect got a unexpected request-response combination - sending 'ls'
[2021-03-15 15:29:45.984203000][th:584649][warning] listener_mgr can not negotiate protocols, other side has violated a protocol and sent an unexpected message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant