Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Notifications are racy #10

Open
Stebalien opened this issue Oct 30, 2017 · 2 comments
Open

Notifications are racy #10

Stebalien opened this issue Oct 30, 2017 · 2 comments

Comments

@Stebalien
Copy link
Member

We notify in parallel (per notification). This means that anything trying to tag connections before the connection manager finishes registering the connection will fail.

One way to fix this is to add an IsConnected method to connections (would be nice to have anyways and we generally have this at lower levels) and start tracking active connections before we actually receive a notification.

Thoughts @whyrusleeping?

@Stebalien
Copy link
Member Author

Related to ipfs/kubo#4353.

@Stebalien
Copy link
Member Author

Actually, the "IsConnected" method won't help. However, the conn manager will need access to the swarm (which it doesn't currently have).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant